You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/12/24 01:52:52 UTC

[GitHub] [apisix] tokers commented on a change in pull request #5897: feat(plugin): add degradation switch for ext-plugin

tokers commented on a change in pull request #5897:
URL: https://github.com/apache/apisix/pull/5897#discussion_r774836323



##########
File path: apisix/plugins/ext-plugin/init.lua
##########
@@ -700,6 +701,9 @@ function _M.communicate(conf, ctx, plugin_name)
 
         if not core.string.find(err, "conf token not found") then
             core.log.error(err)
+            if conf.allow_degradation then
+                return

Review comment:
       Let's add a logging message here? So we can detect the degradation situation, also, we can enrich our test cases.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org