You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/06/23 10:30:21 UTC
Re: Review Request 34712: ambari-agent.out file grows geometrically
and quickly fills up disk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34712/
-----------------------------------------------------------
(Updated June 23, 2015, 8:30 a.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-11349
https://issues.apache.org/jira/browse/AMBARI-11349
Repository: ambari
Description
-------
See attached files. This came from a devdeploy test where some service check
was failing due to lack of disk space (BUG - 37173). ambari-agent.out was not
the reason but was the largest contributor.
Can you check if we can avoid logging to the out file unless there was an
error due to which this is expected?
If out file does not roll this could be an issue in the long run.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 1263195
ambari-common/src/main/python/resource_management/core/logger.py 1d6ace2
Diff: https://reviews.apache.org/r/34712/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 34712: ambari-agent.out file grows geometrically
and quickly fills up disk
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34712/#review88939
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On June 23, 2015, 8:30 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34712/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 8:30 a.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-11349
> https://issues.apache.org/jira/browse/AMBARI-11349
>
>
> Repository: ambari
>
>
> Description
> -------
>
> See attached files. This came from a devdeploy test where some service check
> was failing due to lack of disk space (BUG - 37173). ambari-agent.out was not
> the reason but was the largest contributor.
>
> Can you check if we can avoid logging to the out file unless there was an
> error due to which this is expected?
>
> If out file does not roll this could be an issue in the long run.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 1263195
> ambari-common/src/main/python/resource_management/core/logger.py 1d6ace2
>
> Diff: https://reviews.apache.org/r/34712/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>