[GitHub] [spark] cloud-fan commented on a change in pull request #34647: [SPARK-36180][SQL] Support TimestampNTZ type in Hive

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34647:
URL: https://github.com/apache/spark/pull/34647#discussion_r754236576



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala
##########
@@ -392,6 +392,8 @@ object DataType {
               equalsIgnoreCaseAndNullability(l.dataType, r.dataType)
           }
 
+      case (TimestampNTZType, TimestampType) => true

Review comment:
       This is definitely not OK. We can't change the semantic of `equalsIgnoreCaseAndNullability`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org