[GitHub] [flink-statefun] sjwiesman commented on a change in pull request #42: [FLINK-16390][sdk] Add view and clear methods to PersistedTable

[GitBox <gi...@apache.org>]

sjwiesman commented on a change in pull request #42: [FLINK-16390][sdk] Add view and clear methods to PersistedTable
URL: https://github.com/apache/flink-statefun/pull/42#discussion_r387092147
 
 

 ##########
 File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/state/FlinkTableAccessor.java
 ##########
 @@ -55,4 +57,19 @@ public void remove(K key) {
       throw new RuntimeException(e);
     }
   }
+
+  @Override
+  public Iterable<Map.Entry<K, V>> view() {
+    try {
+      Iterable<Map.Entry<K, V>> entries = handle.entries();
+      return entries == null ? Collections.emptyList() : entries;
 
 Review comment:
   Looks like I have some Flink jobs I can remove some null checks from :) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services