You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2015/11/23 22:21:50 UTC
[GitHub] storm pull request: STORM-1340: Use Travis-CI build matrix to impr...
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/902
STORM-1340: Use Travis-CI build matrix to improve test execution times
This patch modifies the Travis-CI config to run storm-core unit tests in parallel with all the external tests, knocking between 4 and 7 minutes off the build time usually.
It also caches ruby, javascript, and java libraries instead of downloading them each time a container is launched.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-1340
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/902.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #902
----
commit a0e734727d2335bb0e7a12f8ada8ca07f4908ded
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2015-11-10T20:27:21Z
Adding setting to travis.
commit 146a893647267736b01c458dde9a1b0150194b67
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2015-11-10T22:01:14Z
Add caching to speed up build.
commit 56297183c86404fb4fe3d623e47808c07b961471
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2015-11-10T22:17:58Z
Kicking Travis
commit f0630adb057a4f3dc321e51d14610639753d07e7
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2015-11-10T22:40:19Z
Testing travis matrix.
commit 103f71a00a6c41a83349f39a420c2a2d0807ddb7
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2015-11-10T22:44:24Z
Testing
Testing
Testing
Testing
Testing
Testing
Testing
Testing
Fixing .travis.yml
commit e83678b8fba07f921b661ab0b2a40616726dec55
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2015-11-11T00:13:43Z
Cleanup
commit 77417554f1880e113177c874e45ed5721f94b06e
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2015-11-19T17:31:52Z
Testing split-up travis.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1340: Use Travis-CI build matrix to impr...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/902#issuecomment-159092312
Failure looks unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1340: Use Travis-CI build matrix to impr...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/902#discussion_r45664250
--- Diff: dev-tools/travis/travis-install.sh ---
@@ -29,6 +29,7 @@ TRAVIS_SCRIPT_DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
cd ${STORM_SRC_ROOT_DIR}
python ${TRAVIS_SCRIPT_DIR}/save-logs.py "install.txt" mvn clean install -DskipTests -Pnative --batch-mode
+
--- End diff --
revert?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1340: Use Travis-CI build matrix to impr...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/902#issuecomment-159314711
@HeartSaVioR Would you like to look at this?
It's similar to the PR I put up before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1340: Use Travis-CI build matrix to impr...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/902#issuecomment-159088673
Looks good to me drops the build time by about 7 mins. I am +1 if you can address @d2r comment and squash yur changes. 11 commits feels like a bit much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1340: Use Travis-CI build matrix to impr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/902
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1340: Use Travis-CI build matrix to impr...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/902#issuecomment-159346298
@knusbaum
I'm +1 for the change.
Actually I found some builds before rebase still takes 13 min or higher, but mostly it seems to save build time.
Great work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1340: Use Travis-CI build matrix to impr...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/902#issuecomment-159093376
Looks good to me +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---