You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2017/03/22 16:35:10 UTC
[GitHub] thrift pull request #1219: THRIFT-4079: emit use clauses in Types.pm generat...
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1219
THRIFT-4079: emit use clauses in Types.pm generated files as well (fix reopened defect)
The original fix only took care of the generated file for the service, if the service has a method that uses a structure from an included thrift file, use clauses were emitted.
The issue was re-opened because if a structure in one thrift file contains a field for a structure defined in another thrift file, the perl generated code doesn't work properly as described in the defect since these live in Types.pm, and it needs the same use clauses emitted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4079
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1219.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1219
----
commit bfefdc33a0510b436efc7687fd29bf054e7d1ba8
Author: James E. King, III <ji...@simplivity.com>
Date: 2017-03-22T16:31:35Z
THRIFT-4079: emit use clauses in Types.pm generated files as well (fix reopened defect)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1219: THRIFT-4079: emit use clauses in Types.pm generat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1219
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---