You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/29 11:04:37 UTC
[GitHub] [airflow] JPFrancoia opened a new pull request #7954: Pinning max
pandas version to 2.0 (lesser than) to allow pandas 1.0.
JPFrancoia opened a new pull request #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954
Issue link: https://github.com/apache/airflow/issues/7905
Currently on master, pandas is pinned to < 1.0.0 in Airflow's dependencies. Version 1.0 was released in October 31, 2019. Lots of projects are starting to migrate to pandas 1.0 and it will gradually become more and more difficult to solve conflicts between their dependencies and Airflow's dependencies.
This PR increases the max version of pandas to `2.0`, which will allow installing pandas 1.0. The minimum pandas version stays unchanged so all existing projects with pandas version pinned to `1.0` shouldn't be impacted.
My commit passed the pre-commits. I installed (or tried to) installed as much dependencies as possible in the `all` extra (in a local virtualenv), and ran as much unit tests as possible before upgrading pandas. This was my baseline. I then upgraded pandas to 1.0.3 and ran the same tests again and the number of failed tests didn't decrease.
I'm sorry I can't give a clearer answer on whether pandas' version will break something, but testing has proven to be difficult: the integration tests are tangled with the unit tests and it's unclear to me which tests should pass or not. Help is appreciated.
- [x ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7954: Pinning max pandas
version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-605934613
Hello @JPFrancoia -> it's merged, so you can rebase now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7954: Pinning max pandas
version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-605805420
Hello @JPFrancoia -> it looks good but I would like to wait until we merge #7980 . Then I will ask you to rebase it on top of the latest master. What happened in the current case (if you look closely) was that even if you added <2.0 exclusion, Pandas were not upgraded. This is exactly what #7980 is addressing. When you rebase, you will have to run generate-requirements again (this time panda should get bumped to 2.0 for both python versions) and you should re-push the change. Then we will actually test if Pandas 1.0 is OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] JPFrancoia commented on issue #7954: Pinning max pandas
version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
JPFrancoia commented on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-605629940
I forked from master this morning, I think I'm up to date.
Regarding the generation of the requirements files: everything seems to run fine, I get that for example:
```
Successfully installed apache-airflow
You are using pip version 19.0.2, however version 20.0.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Copying requirements /opt/airflow/requirements/requirements-python3.6.txt -> /tmp/requirements-python3.6.txt
Freezing requirements to /opt/airflow/requirements/requirements-python3.6.txt
Requirements generated in /opt/airflow/requirements/requirements-python3.6.txt
```
But I can't find the requirement file, neither in `/opt/airflow/requirements/requirements-python3.6.txt` or in `/tmp/requirements-python3.6.txt`. Is it expected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7954: Pinning max pandas
version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk edited a comment on issue #7954: Pinning max
pandas version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-605625100
Please rebase to latest master to fix a problem that I've fixed yesterday. Also just yesterday we've merged a change that will help with managing requirements. It's best if you use Breeze to run `breeze generate-requirements --python 3.6` and `breeze generate-requirements --python 3.7` to regenerate fixed set of requirements in "requirements" folder.
See a brand new chapter (and the following ones) in the Contributing guide about it. https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#airflow-dependencies
BTW. After reading to the latest master you will get a failing "generate requirements" build in case you do not run it and those instructions will be printed in the log of failing build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7954: Pinning max pandas
version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-605674931
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7954?src=pr&el=h1) Report
> Merging [#7954](https://codecov.io/gh/apache/airflow/pull/7954?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/daad60b9174ecb44ac9d363c81d4f1ca54679610&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7954?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7954 +/- ##
==========================================
- Coverage 87.16% 86.90% -0.26%
==========================================
Files 931 932 +1
Lines 45173 45187 +14
==========================================
- Hits 39375 39270 -105
- Misses 5798 5917 +119
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7954?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7954/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7954/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7954/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7954/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7954/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [...ud/example\_dags/example\_kubernetes\_engine\_setup.py](https://codecov.io/gh/apache/airflow/pull/7954/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2t1YmVybmV0ZXNfZW5naW5lX3NldHVwLnB5) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7954?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7954?src=pr&el=footer). Last update [daad60b...39134cc](https://codecov.io/gh/apache/airflow/pull/7954?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7954: Pinning max
pandas version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-605619067
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] JPFrancoia commented on issue #7954: Pinning max pandas
version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
JPFrancoia commented on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-606155346
Ah, I understand now. Ok, I rebased and regenerated the requirements files. Let's see what happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7954: Pinning max
pandas version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-606243232
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] JPFrancoia commented on issue #7954: Pinning max pandas
version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
JPFrancoia commented on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-606247982
Thanks for your guidance @potiuk .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7954: Pinning max pandas
version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-605625100
Please rebase to latest master to fix a problem that I've fixed yesterday. Also just yesterday we've merged a change that will help with managing requirements. It's best if you use Breeze to run `breeze generate-requirements --python 3.6` and `breeze generate-requirements --python 3.7` to regenerate fixed set of requirements in "requirements" folder.
See a brand new chapter (and the following ones) in the Contributing guide about it. https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#airflow-dependencies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] JPFrancoia edited a comment on issue #7954: Pinning max
pandas version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
JPFrancoia edited a comment on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-605629940
I forked from master this morning (a couple hours ago), I think I'm up to date.
Regarding the generation of the requirements files: everything seems to run fine, I get that for example:
```
Successfully installed apache-airflow
You are using pip version 19.0.2, however version 20.0.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Copying requirements /opt/airflow/requirements/requirements-python3.6.txt -> /tmp/requirements-python3.6.txt
Freezing requirements to /opt/airflow/requirements/requirements-python3.6.txt
Requirements generated in /opt/airflow/requirements/requirements-python3.6.txt
```
But I can't find the requirement file, neither in `/opt/airflow/requirements/requirements-python3.6.txt` or in `/tmp/requirements-python3.6.txt`. Is it expected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk edited a comment on issue #7954: Pinning max
pandas version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-605625100
Please rebase to latest master to fix a problem that I've fixed yesterday. Also just yesterday we've merged a change that will help with managing requirements. It's best if you use Breeze to run `breeze generate-requirements --python 3.6` and `breeze generate-requirements --python 3.7` to regenerate fixed set of requirements in "requirements" folder.
See a brand new chapter (and the following ones) in the Contributing guide about it. https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#airflow-dependencies
BTW. After rebasing to the latest master you will get a failing "generate requirements" build in case you do not run it and those instructions will be printed in the log of failing build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] JPFrancoia commented on issue #7954: Pinning max pandas
version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
JPFrancoia commented on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-606224723
Nothing broke \o/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7954: Pinning max pandas
version to 2.0 (lesser than) to allow pandas 1.0.
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7954: Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0.
URL: https://github.com/apache/airflow/pull/7954#issuecomment-606243358
Cool!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services