You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jena.apache.org by afs <gi...@git.apache.org> on 2018/05/12 15:54:48 UTC

[GitHub] jena pull request #421: Escape @xerces.internal annotations

GitHub user afs opened a pull request:

    https://github.com/apache/jena/pull/421

    Escape @xerces.internal annotations

    Replace "@xerces.internal" with "{@literal @xerces.internal}".
    
    This suppresses javadoc warning about unknown javadoc tags.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afs/jena more-javadoc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #421
    
----
commit dd5f4f4d58d85b7f43a5dfd7867376fec0fbc0dd
Author: Andy Seaborne <an...@...>
Date:   2018-05-12T15:51:37Z

    Escape @xerces.internal annotations

----


---

[GitHub] jena issue #421: Escape @xerces.internal annotations

Posted by ajs6f <gi...@git.apache.org>.

Github user ajs6f commented on the issue:

    https://github.com/apache/jena/pull/421
  
    I've never seen `@xerces.internal` before, but it seems to denote types internal to Xerces, right? My one question is: do we need to keep it on all types or can we stick it on a package comment? (Since we're not planning on maintaining a separate "branch" of Xerces as a whole.)


---

[GitHub] jena issue #421: Escape @xerces.internal annotations

Posted by afs <gi...@git.apache.org>.

Github user afs commented on the issue:

    https://github.com/apache/jena/pull/421
  
    The PR leaves the code as much as-is by escaping the annotation in a `{@literal ...}`.  By making this reversible change, comparing to the original easier, if it is ever needed. We could remove it completely. It does not do anything.



---

[GitHub] jena issue #421: Escape @xerces.internal annotations

Posted by ajs6f <gi...@git.apache.org>.

Github user ajs6f commented on the issue:

    https://github.com/apache/jena/pull/421
  
    Okay, either way works for me. This is already done, so easier!


---

[GitHub] jena pull request #421: Escape @xerces.internal annotations

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/jena/pull/421


---