You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Selvamohan Neethiraj <sn...@hortonworks.com> on 2018/02/13 04:02:18 UTC

Review Request 65623: ATLAS-2438: fix errors found in sitecheck - https://whimsy.apache.org/site/project/atlas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65623/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-2438
    https://issues.apache.org/jira/browse/ATLAS-2438


Repository: atlas


Description
-------

Modified to show licenses url correctly and added trademark and events links in the doc site.


Diffs
-----

  docs/src/site/site.xml 2cf4e844 
  docs/src/site/twiki/index.twiki 8345f049 


Diff: https://reviews.apache.org/r/65623/diff/1/


Testing
-------

Build the doc using 
$ mvn clean site

Verified the generated content in target/site folder to validate changes in the generated website content


Thanks,

Selvamohan Neethiraj


Re: Review Request 65623: ATLAS-2438: fix errors found in sitecheck - https://whimsy.apache.org/site/project/atlas

Posted by Graham Wallis <gr...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65623/#review197392
-----------------------------------------------------------



Thanks for fixing this. One very minor point is the whitespace error in the patch - i.e. the part that is color red in the diff - I think this is due to a tab rather than space characters. I know it's minor but it would be good to remove before committing the patch. Thanks again.

- Graham Wallis


On Feb. 13, 2018, 4:02 a.m., Selvamohan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65623/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2018, 4:02 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2438
>     https://issues.apache.org/jira/browse/ATLAS-2438
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Modified to show licenses url correctly and added trademark and events links in the doc site.
> 
> 
> Diffs
> -----
> 
>   docs/src/site/site.xml 2cf4e844 
>   docs/src/site/twiki/index.twiki 8345f049 
> 
> 
> Diff: https://reviews.apache.org/r/65623/diff/1/
> 
> 
> Testing
> -------
> 
> Build the doc using 
> $ mvn clean site
> 
> Verified the generated content in target/site folder to validate changes in the generated website content
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>


Re: Review Request 65623: ATLAS-2438: fix errors found in sitecheck - https://whimsy.apache.org/site/project/atlas

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65623/#review197375
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 13, 2018, 4:02 a.m., Selvamohan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65623/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2018, 4:02 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2438
>     https://issues.apache.org/jira/browse/ATLAS-2438
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Modified to show licenses url correctly and added trademark and events links in the doc site.
> 
> 
> Diffs
> -----
> 
>   docs/src/site/site.xml 2cf4e844 
>   docs/src/site/twiki/index.twiki 8345f049 
> 
> 
> Diff: https://reviews.apache.org/r/65623/diff/1/
> 
> 
> Testing
> -------
> 
> Build the doc using 
> $ mvn clean site
> 
> Verified the generated content in target/site folder to validate changes in the generated website content
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>