You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/07/21 07:40:11 UTC
Review Request 61021: RANGER-1672:Ranger supports plugin to enable,
monitor and manage apache kylin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
Bugs: RANGER-1672
https://issues.apache.org/jira/browse/RANGER-1672
Repository: ranger
Description
-------
Ranger supports plugin to enable, monitor and manage apache kylin
Diffs
-----
agents-common/scripts/enable-agent.sh d31a264
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
plugin-kylin/.gitignore PRE-CREATION
plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
plugin-kylin/pom.xml PRE-CREATION
plugin-kylin/scripts/install.properties PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinConnectionMgr.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
pom.xml 3fcc4aa
ranger-kylin-plugin-shim/.gitignore PRE-CREATION
ranger-kylin-plugin-shim/pom.xml PRE-CREATION
ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9742265
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 722a566
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 6e9161e
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js af7bdfe
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5d
src/main/assembly/admin-web.xml cb1aad2
src/main/assembly/plugin-kylin.xml PRE-CREATION
Diff: https://reviews.apache.org/r/61021/diff/1/
Testing
-------
Tested
Thanks,
Qiang Zhang
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review181339
-----------------------------------------------------------
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
Lines 198 (patched)
<https://reviews.apache.org/r/61021/#comment256879>
Can we move variable declaration statements to top of function start ?
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
Line 208 (original), 213 (patched)
<https://reviews.apache.org/r/61021/#comment256880>
As per the changes looks like query params `service` and `service name` are only required for populating the users drop-down and also for user rest call in kyline component only.
However since this is a common code the params will be added to ALL rest calls made from other components also.
Please modify this code to send the params only for kyline component.
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
Lines 219 (patched)
<https://reviews.apache.org/r/61021/#comment256881>
Here as per the changes looks like we are showing specific hard-coded set of roles in the `Select Role` drop-down and which are not loaded using any of rest call. If that is the requirement, can we remove ajax call for `Select Role` drop-down for this component.
This can done by simply removing `ajax` option from select2 plugin and setting `tags` attribute to array
like tags : [ROLE_ADMIN','ROLE_MODELER','ROLE_ANALYST']
Note : This case is only applicable for Select Role in kyline component.
Also can we move roles to enum file by simply specifiying `XAEnums.kylinRole` in XAEnum file?
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
Line 235 (original), 245 (patched)
<https://reviews.apache.org/r/61021/#comment256882>
Rename `notMath` to `noMatch`.
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
Lines 265 (patched)
<https://reviews.apache.org/r/61021/#comment256883>
Can we create util function to check service definition is of kyline or not in `XAUtil.js` file? So that we can reuse it like we use `XAUtils.isTagServiceDef()`.
- Nitin Galave
On July 21, 2017, 7:40 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 7:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinConnectionMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 3fcc4aa
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9742265
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 722a566
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 6e9161e
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js af7bdfe
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5d
> src/main/assembly/admin-web.xml cb1aad2
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/1/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On 七月 25, 2017, 1:56 p.m., Pradeep Agrawal wrote:
> > pom.xml
> > Lines 217 (patched)
> > <https://reviews.apache.org/r/61021/diff/1/?file=1780611#file1780611line217>
> >
> > mvn build is not working for me. Can you please add steps to build Ranger admin with this patch.
>
> Qiang Zhang wrote:
> This patch relies on kylin's new patch,
> please refer kylin issue : https://issues.apache.org/jira/browse/KYLIN-2703,
> therefore, you need to apply the kylin patch first, and build kylin with viersion 2.1.0-SNAPSHOT,
> then you can build Ranger admin with this patch.
>
> Colm O hEigeartaigh wrote:
> How likely is it that a Kylin release containing KYLIN-2703 will be available before we release Ranger 1.0.0?
This is a big feature for kylin. Kylin's PMC had sent mail to us that they are organizing committer to review https://issues.apache.org/jira/browse/KYLIN-2703 .
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review181341
-----------------------------------------------------------
On 七月 21, 2017, 7:40 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated 七月 21, 2017, 7:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinConnectionMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 3fcc4aa
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9742265
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 722a566
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 6e9161e
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js af7bdfe
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5d
> src/main/assembly/admin-web.xml cb1aad2
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/1/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On July 25, 2017, 1:56 p.m., Pradeep Agrawal wrote:
> > pom.xml
> > Lines 217 (patched)
> > <https://reviews.apache.org/r/61021/diff/1/?file=1780611#file1780611line217>
> >
> > mvn build is not working for me. Can you please add steps to build Ranger admin with this patch.
>
> Qiang Zhang wrote:
> This patch relies on kylin's new patch,
> please refer kylin issue : https://issues.apache.org/jira/browse/KYLIN-2703,
> therefore, you need to apply the kylin patch first, and build kylin with viersion 2.1.0-SNAPSHOT,
> then you can build Ranger admin with this patch.
How likely is it that a Kylin release containing KYLIN-2703 will be available before we release Ranger 1.0.0?
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review181341
-----------------------------------------------------------
On July 21, 2017, 7:40 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 7:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinConnectionMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 3fcc4aa
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9742265
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 722a566
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 6e9161e
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js af7bdfe
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5d
> src/main/assembly/admin-web.xml cb1aad2
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/1/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On 七月 25, 2017, 1:56 p.m., Pradeep Agrawal wrote:
> > pom.xml
> > Lines 217 (patched)
> > <https://reviews.apache.org/r/61021/diff/1/?file=1780611#file1780611line217>
> >
> > mvn build is not working for me. Can you please add steps to build Ranger admin with this patch.
This patch relies on kylin's new patch,
please refer kylin issue : https://issues.apache.org/jira/browse/KYLIN-2703,
therefore, you need to apply the kylin patch first, and build kylin with viersion 2.1.0-SNAPSHOT,
then you can build Ranger admin with this patch.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review181341
-----------------------------------------------------------
On 七月 21, 2017, 7:40 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated 七月 21, 2017, 7:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinConnectionMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 3fcc4aa
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9742265
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 722a566
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 6e9161e
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js af7bdfe
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5d
> src/main/assembly/admin-web.xml cb1aad2
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/1/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Pradeep Agrawal <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review181341
-----------------------------------------------------------
pom.xml
Lines 217 (patched)
<https://reviews.apache.org/r/61021/#comment256885>
mvn build is not working for me. Can you please add steps to build Ranger admin with this patch.
- Pradeep Agrawal
On July 21, 2017, 7:40 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 7:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinConnectionMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 3fcc4aa
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9742265
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 722a566
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 6e9161e
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js af7bdfe
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5d
> src/main/assembly/admin-web.xml cb1aad2
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/1/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Ramesh Mani <rm...@hortonworks.com>.
> On July 24, 2017, 11:17 p.m., Ramesh Mani wrote:
> >
This seems to be interesting contribution! Thanks.
- Ramesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review181282
-----------------------------------------------------------
On July 21, 2017, 7:40 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 7:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinConnectionMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 3fcc4aa
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9742265
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 722a566
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 6e9161e
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js af7bdfe
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5d
> src/main/assembly/admin-web.xml cb1aad2
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/1/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review181282
-----------------------------------------------------------
agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json
Lines 18 (patched)
<https://reviews.apache.org/r/61021/#comment256808>
Is this going to be "String" to be Matched. If so use org.apache.ranger.plugin.resourcematcher.RangerDefaultResourceMatcher. Refer ranger-servicedef-hive.json for it.
plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java
Lines 71 (patched)
<https://reviews.apache.org/r/61021/#comment256810>
Why there is a check for "Cube" first and then "Project". Is there a resource hierarchy like Project -> cubes. If so does the "Project" has to be a another resource in the resource definition? Please review this and update. Refer Hive Plugin if needed.
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
Line 2764 (original), 2769 (patched)
<https://reviews.apache.org/r/61021/#comment256812>
User/Group and default policy should be moved to org.apache.ranger.services.hdfs.RangerServiceKylin. You need to create one and refer it in ranger-servicedef-kylin.json.
ServiceDBStore.java should have call only to createDefaultPolicy(). This class should not be changed as such.
Refer HDFS/KMS plugin and getDefaultRangerPolicies for those plugin in org.apache.ranger.services.hdfs.RangerService
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java
Lines 581 (patched)
<https://reviews.apache.org/r/61021/#comment256815>
searchKylinUsers should be done in SearchUtil.java. THis class as such cannot be changed. It is only for Service related calls. Please move this out and place it in SearchUtil. Look at other calls in XUserREST.java
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java
Lines 372 (patched)
<https://reviews.apache.org/r/61021/#comment256818>
Repeated class kylinUserResponse. Make it part of Util class
- Ramesh Mani
On July 21, 2017, 7:40 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 7:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinConnectionMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 3fcc4aa
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9742265
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 722a566
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 6e9161e
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js af7bdfe
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5d
> src/main/assembly/admin-web.xml cb1aad2
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/1/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Zsombor Gegesy <gz...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review182699
-----------------------------------------------------------
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
Lines 195 (patched)
<https://reviews.apache.org/r/61021/#comment258680>
Probably a much bigger change, but ideally, in the web module, there shouldn't be much any service or kylin specific thing.
It would be better to put these kylin roles in the service defs, under for example 'extra options' or some other structure. So next time, when a new service would need a similar functionality, it could reuse the code - and not in a 'copy-paste' sense :)
- Zsombor Gegesy
On Aug. 8, 2017, 2:08 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2017, 2:08 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java f1c6b9f
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 01005b7
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 1979847
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
> src/main/assembly/admin-web.xml cb1aad2
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/2/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review182681
-----------------------------------------------------------
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
Lines 196 (patched)
<https://reviews.apache.org/r/61021/#comment258670>
Suggestion: Can you provide options to select2 based on service definition is kylin or not instead of defining select2 two times?
like select2(options);
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
Lines 201 (patched)
<https://reviews.apache.org/r/61021/#comment258669>
As per changes look like for `Role` drop-down in the policy item:
`Select Role` drop-down allows the user to add a new role.(i.e user defined role)
Is this requirement?
- Nitin Galave
On Aug. 8, 2017, 2:08 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2017, 2:08 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java f1c6b9f
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 01005b7
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 1979847
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
> src/main/assembly/admin-web.xml cb1aad2
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/2/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On 八月 25, 2017, 7:24 a.m., Madhan Neethiraj wrote:
> > Qiang Zhang - it is good to see addition of new Ranger plugin. Good work! Please go through review comments. Overall, the plugin implementation looks good.
Ok. Thanks.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review183830
-----------------------------------------------------------
On 八月 8, 2017, 2:08 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated 八月 8, 2017, 2:08 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java f1c6b9f
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 01005b7
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 1979847
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
> src/main/assembly/admin-web.xml cb1aad2
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/2/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review183830
-----------------------------------------------------------
Qiang Zhang - it is good to see addition of new Ranger plugin. Good work! Please go through review comments. Overall, the plugin implementation looks good.
plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java
Lines 95 (patched)
<https://reviews.apache.org/r/61021/#comment259902>
Looks like auditHandler will never be null here, given its initialization above in line #81. Consider moving line #96 inside the 'if' block that ends at #93.
plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java
Lines 109 (patched)
<https://reviews.apache.org/r/61021/#comment259903>
This will get the IP address of the host where the plugin runs. Is this intentional? If yes, perhaps you can get this value during plugin initalization and use it for all request. This is unlikley to change across authorization requests.
plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java
Lines 167 (patched)
<https://reviews.apache.org/r/61021/#comment259904>
RangerKylinAuditHandler doesn't seem to handle processResult() differently from RangerDefaultAuditHandler. You can remove this class and instead use RangerDefaultAuditHandler set in line #135. With this, you don't need to pass auditHandler argument in isAccessAllowed() call - line #89.
- Madhan Neethiraj
On Aug. 8, 2017, 2:08 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2017, 2:08 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java f1c6b9f
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 01005b7
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 1979847
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
> src/main/assembly/admin-web.xml cb1aad2
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/2/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review186196
-----------------------------------------------------------
@Colm, Zsombor Gegesy, Ramesh Mani,Nitin Galave, Pradeep Agrawal, Zsombor Gegesy and Madhan Neethiraj, the https://issues.apache.org/jira/browse/KYLIN-2703 had been resolved. So our RANGER-1672 can be resolved now. We have rigorously tested RANGER-1672. Thanks.
- Qiang Zhang
On 九月 22, 2017, 7:48 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> -----------------------------------------------------------
>
> (Updated 九月 22, 2017, 7:48 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger supports plugin to enable, monitor and manage apache kylin
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh d31a264
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 9463ab8
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
> agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
> plugin-kylin/.gitignore PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
> plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
> plugin-kylin/pom.xml PRE-CREATION
> plugin-kylin/scripts/install.properties PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
> pom.xml 3958014
> ranger-kylin-plugin-shim/.gitignore PRE-CREATION
> ranger-kylin-plugin-shim/pom.xml PRE-CREATION
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
> src/main/assembly/admin-web.xml 0e97818
> src/main/assembly/plugin-kylin.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61021/diff/3/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/
-----------------------------------------------------------
(Updated 九月 22, 2017, 7:48 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
Changes
-------
Fixed patch according to the reviews, major modifications:
1.Remove the special processing of Group(Role) and Permissions for kylin in the create/edit policy web page.
Kylin use LDAP/AD authentication integration and support the Hadoop user-group mapping facility.
2.Remove the special processing of Group(Role) for kylin in the Java background.
3.Based on the refactored authorization interfaces of Kylin, modify Ranger Kylin Plugin implements to fit changes.
4.Kylin authorization interfaces is available in Kylin master with version 2.2.0-SNAPSHOT,
you can build kylin to test this patch manually, or wait kylin next release.
5.Ohter small modifications for optimization.
Bugs: RANGER-1672
https://issues.apache.org/jira/browse/RANGER-1672
Repository: ranger
Description
-------
Ranger supports plugin to enable, monitor and manage apache kylin
Diffs (updated)
-----
agents-common/scripts/enable-agent.sh d31a264
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 9463ab8
agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
plugin-kylin/.gitignore PRE-CREATION
plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
plugin-kylin/pom.xml PRE-CREATION
plugin-kylin/scripts/install.properties PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
pom.xml 3958014
ranger-kylin-plugin-shim/.gitignore PRE-CREATION
ranger-kylin-plugin-shim/pom.xml PRE-CREATION
ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
src/main/assembly/admin-web.xml 0e97818
src/main/assembly/plugin-kylin.xml PRE-CREATION
Diff: https://reviews.apache.org/r/61021/diff/3/
Changes: https://reviews.apache.org/r/61021/diff/2-3/
Testing
-------
Tested
Thanks,
Qiang Zhang
Re: Review Request 61021: RANGER-1672:Ranger supports plugin to
enable, monitor and manage apache kylin
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/
-----------------------------------------------------------
(Updated 八月 8, 2017, 2:08 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
Changes
-------
Fixed patch according to the reviews, major modifications:
1.Add "Project" as a another resource in the resource definition
2.Remove search user by calling kylin rest api
3.Optimized authentication(checkPermission)
4.Ohter small modifications
Bugs: RANGER-1672
https://issues.apache.org/jira/browse/RANGER-1672
Repository: ranger
Description
-------
Ranger supports plugin to enable, monitor and manage apache kylin
Diffs (updated)
-----
agents-common/scripts/enable-agent.sh d31a264
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java f1c6b9f
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 0bc09f6
agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35
agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json PRE-CREATION
plugin-kylin/.gitignore PRE-CREATION
plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION
plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION
plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION
plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION
plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION
plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION
plugin-kylin/pom.xml PRE-CREATION
plugin-kylin/scripts/install.properties PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java PRE-CREATION
plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java PRE-CREATION
pom.xml 01005b7
ranger-kylin-plugin-shim/.gitignore PRE-CREATION
ranger-kylin-plugin-shim/pom.xml PRE-CREATION
ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java PRE-CREATION
security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939
security-admin/src/main/webapp/scripts/utils/XAUtils.js 1979847
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 067bf3b
src/main/assembly/admin-web.xml cb1aad2
src/main/assembly/plugin-kylin.xml PRE-CREATION
Diff: https://reviews.apache.org/r/61021/diff/2/
Changes: https://reviews.apache.org/r/61021/diff/1-2/
Testing
-------
Tested
Thanks,
Qiang Zhang