You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/21 23:48:51 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19404: Numpy argmin optimization
Zha0q1 opened a new pull request #19404:
URL: https://github.com/apache/incubator-mxnet/pull/19404
This pr applies the argmax optimization https://github.com/apache/incubator-mxnet/pull/19339 to argmin and updates the tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19404: Numpy argmin optimization
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19404:
URL: https://github.com/apache/incubator-mxnet/pull/19404#issuecomment-714753737
> Can you please post before and after benchmark test results?
Yeah, the performance improvement is about the same as seen on argmax.
I just ran the benchmarks again on argmin:
Contiguous:
> (300000, 64) float axis=1
> before: 14.0549
> now: 3.2826
>
> (64, 300000) float axis=1
> before: 376.1702
> now: 3.0881
Non-contiguous:
> (300000, 64) float axis=0
> before: 268.1024
> now: 3.6338
>
> (64, 300000) float axis=0
> before: 1.5355
> now: 2.8061
unit is ms
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19404: Numpy argmin optimization
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19404:
URL: https://github.com/apache/incubator-mxnet/pull/19404#issuecomment-714661132
@sandeep-krishnamurthy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19404: Numpy argmin optimization
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19404:
URL: https://github.com/apache/incubator-mxnet/pull/19404#issuecomment-714755873
CPU
Contiguous:
> (300000, 64) float axis=1
> before: 38.3453
> now: 65.8971
>
> (64, 300000) float axis=1
> before: 35.6059
> now: 62.2148
Non-contiguous:
(300000, 64) float axis=0
before: 994.6203
now: 194.5434
(64, 300000) float axis=0
before: 711.3664
now: 76.4318
unit is ms
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #19404: Numpy argmin optimization
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #19404:
URL: https://github.com/apache/incubator-mxnet/pull/19404#issuecomment-714713674
Can you please post before and after benchmark test results?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 edited a comment on pull request #19404: Numpy argmin optimization
Posted by GitBox <gi...@apache.org>.
Zha0q1 edited a comment on pull request #19404:
URL: https://github.com/apache/incubator-mxnet/pull/19404#issuecomment-714753737
> Can you please post before and after benchmark test results?
Yeah, the performance improvement is about the same as seen on argmax.
I just ran the benchmarks again on argmin:
GPU
Contiguous:
> (300000, 64) float axis=1
> before: 14.0549
> now: 3.2826
>
> (64, 300000) float axis=1
> before: 376.1702
> now: 3.0881
Non-contiguous:
> (300000, 64) float axis=0
> before: 268.1024
> now: 3.6338
>
> (64, 300000) float axis=0
> before: 1.5355
> now: 2.8061
unit is ms
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience merged pull request #19404: Numpy argmin optimization
Posted by GitBox <gi...@apache.org>.
sxjscience merged pull request #19404:
URL: https://github.com/apache/incubator-mxnet/pull/19404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience commented on pull request #19404: Numpy argmin optimization
Posted by GitBox <gi...@apache.org>.
sxjscience commented on pull request #19404:
URL: https://github.com/apache/incubator-mxnet/pull/19404#issuecomment-714672100
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 edited a comment on pull request #19404: Numpy argmin optimization
Posted by GitBox <gi...@apache.org>.
Zha0q1 edited a comment on pull request #19404:
URL: https://github.com/apache/incubator-mxnet/pull/19404#issuecomment-714661132
@sandeep-krishnamurthy @sxjscience
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19404: Numpy argmin optimization
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19404:
URL: https://github.com/apache/incubator-mxnet/pull/19404#issuecomment-714006157
Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, sanity, windows-cpu, centos-gpu, miscellaneous, centos-cpu, unix-cpu, website, unix-gpu, windows-gpu, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org