You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Michael Vorburger (Jira)" <ji...@apache.org> on 2020/06/02 05:46:00 UTC
[jira] [Updated] (FINERACT-1016) Flaky
RecurringDepositTest.testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days()
[ https://issues.apache.org/jira/browse/FINERACT-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Vorburger updated FINERACT-1016:
----------------------------------------
Description:
See comments in FINERACT-855 from yesterday and today re. testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days():
{code:java}org.apache.fineract.integrationtests.RecurringDepositTest > testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days FAILED
java.lang.AssertionError: Verifying Pre-Closure maturity amount expected:<4005.0> but was:<4006.0>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:120)
at org.apache.fineract.integrationtests.RecurringDepositTest.testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days(RecurringDepositTest.java:2161){code}
Because this problem probably actually has nothing at all to do with the testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX() failure which FINERACT-855 was originally about, so let's track this separately here.
This testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days() failure today seems to have nothing to do with the Job Scheduler (for once), but appears to be some date related mess.
That test today right for me reliably fails locally, but when I change my system date back a few days to late May, then it passes. So either the test, or worse even the actual logic being tested, has some bug in date handling.
was:
See comments in FINERACT-855 from yesterday and today re. testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days():
That problem actually probably actually has nothing at all to do with the testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX() failure which FINERACT-855 was originally about, so let's track this separately here.
The testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days() failure today seems to have nothing to do with the Job Scheduler (for once), but appears to be some date related mess.
That test today right for me reliably fails locally, but when I change my system date back a few days to late May, then it passes. So either the test, or worse even the actual logic being tested, has some bug in date handling.
> Flaky RecurringDepositTest.testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days()
> -------------------------------------------------------------------------------------------------------------
>
> Key: FINERACT-1016
> URL: https://issues.apache.org/jira/browse/FINERACT-1016
> Project: Apache Fineract
> Issue Type: Sub-task
> Reporter: Michael Vorburger
> Priority: Major
>
> See comments in FINERACT-855 from yesterday and today re. testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days():
> {code:java}org.apache.fineract.integrationtests.RecurringDepositTest > testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days FAILED
> java.lang.AssertionError: Verifying Pre-Closure maturity amount expected:<4005.0> but was:<4006.0>
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.failNotEquals(Assert.java:835)
> at org.junit.Assert.assertEquals(Assert.java:120)
> at org.apache.fineract.integrationtests.RecurringDepositTest.testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days(RecurringDepositTest.java:2161){code}
> Because this problem probably actually has nothing at all to do with the testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX() failure which FINERACT-855 was originally about, so let's track this separately here.
> This testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days() failure today seems to have nothing to do with the Job Scheduler (for once), but appears to be some date related mess.
> That test today right for me reliably fails locally, but when I change my system date back a few days to late May, then it passes. So either the test, or worse even the actual logic being tested, has some bug in date handling.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)