You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hemanth Yamijala (JIRA)" <ji...@apache.org> on 2008/10/16 06:46:44 UTC
[jira] Created: (HADOOP-4426) TestCapacityScheduler is broken
TestCapacityScheduler is broken
-------------------------------
Key: HADOOP-4426
URL: https://issues.apache.org/jira/browse/HADOOP-4426
Project: Hadoop Core
Issue Type: Test
Components: contrib/capacity-sched
Affects Versions: 0.19.0
Reporter: Hemanth Yamijala
Assignee: Hemanth Yamijala
Priority: Blocker
Fix For: 0.19.0
The commits for HADOOP-4053 and HADOOP-4373 caused each other's test cases to break. The patches were being worked on in parallel, and hence the break wasn't caught earlier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4426) TestCapacityScheduler is broken
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640071#action_12640071 ]
Hemanth Yamijala commented on HADOOP-4426:
------------------------------------------
Results of ant test-patch:
[exec] +1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
Since this is only affecting the contrib tests, I ran ant test-contrib. All tests passed.
> TestCapacityScheduler is broken
> -------------------------------
>
> Key: HADOOP-4426
> URL: https://issues.apache.org/jira/browse/HADOOP-4426
> Project: Hadoop Core
> Issue Type: Test
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4426.patch
>
>
> The commits for HADOOP-4053 and HADOOP-4373 caused each other's test cases to break. The patches were being worked on in parallel, and hence the break wasn't caught earlier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4426) TestCapacityScheduler is broken
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-4426:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Hemanth!
> TestCapacityScheduler is broken
> -------------------------------
>
> Key: HADOOP-4426
> URL: https://issues.apache.org/jira/browse/HADOOP-4426
> Project: Hadoop Core
> Issue Type: Test
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4426.patch
>
>
> The commits for HADOOP-4053 and HADOOP-4373 caused each other's test cases to break. The patches were being worked on in parallel, and hence the break wasn't caught earlier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4426) TestCapacityScheduler is broken
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640093#action_12640093 ]
Hadoop QA commented on HADOOP-4426:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12392224/HADOOP-4426.patch
against trunk revision 705124.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3472/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3472/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3472/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3472/console
This message is automatically generated.
> TestCapacityScheduler is broken
> -------------------------------
>
> Key: HADOOP-4426
> URL: https://issues.apache.org/jira/browse/HADOOP-4426
> Project: Hadoop Core
> Issue Type: Test
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4426.patch
>
>
> The commits for HADOOP-4053 and HADOOP-4373 caused each other's test cases to break. The patches were being worked on in parallel, and hence the break wasn't caught earlier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4426) TestCapacityScheduler is broken
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-4426:
-------------------------------------
Attachment: HADOOP-4426.patch
{{testJobRunStateChange}} was setting the guaranteed capacity percentage as 1%. Before HADOOP-4373, this would have returned a task nevertheless. Fixed the test case to set it to 100%.
{{testCapacityBasedAllocation}} was broken by changes in HADOOP-4053. As {{jobUpdated}} is not called now from the capacity scheduler, but instead only from the real JobTracker, the job which was to be picked up was not moved to the running queue. The test case is updated to raise the required event.
> TestCapacityScheduler is broken
> -------------------------------
>
> Key: HADOOP-4426
> URL: https://issues.apache.org/jira/browse/HADOOP-4426
> Project: Hadoop Core
> Issue Type: Test
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4426.patch
>
>
> The commits for HADOOP-4053 and HADOOP-4373 caused each other's test cases to break. The patches were being worked on in parallel, and hence the break wasn't caught earlier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4426) TestCapacityScheduler is broken
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640069#action_12640069 ]
Amar Kamat commented on HADOOP-4426:
------------------------------------
bq. testJobRunStateChange was setting the guaranteed capacity percentage as 1%.
+1. Changed it to 100% and it worked fine.
bq. testCapacityBasedAllocation was broken by changes in HADOOP-4053.
Other testcases in {{TestCapacityScheduler}} were also failing and I fixed them by using {{submitJobAndInit()}}. {{submitJobAndInit()}} makes sure that the job gets submitted and also the listeners are informed.
+1 for the short fix.
> TestCapacityScheduler is broken
> -------------------------------
>
> Key: HADOOP-4426
> URL: https://issues.apache.org/jira/browse/HADOOP-4426
> Project: Hadoop Core
> Issue Type: Test
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4426.patch
>
>
> The commits for HADOOP-4053 and HADOOP-4373 caused each other's test cases to break. The patches were being worked on in parallel, and hence the break wasn't caught earlier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4426) TestCapacityScheduler is broken
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-4426:
-------------------------------------
Status: Patch Available (was: Open)
> TestCapacityScheduler is broken
> -------------------------------
>
> Key: HADOOP-4426
> URL: https://issues.apache.org/jira/browse/HADOOP-4426
> Project: Hadoop Core
> Issue Type: Test
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4426.patch
>
>
> The commits for HADOOP-4053 and HADOOP-4373 caused each other's test cases to break. The patches were being worked on in parallel, and hence the break wasn't caught earlier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4426) TestCapacityScheduler is broken
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640200#action_12640200 ]
Hudson commented on HADOOP-4426:
--------------------------------
Integrated in Hadoop-trunk #635 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/635/])
. TestCapacityScheduler broke due to the two commits HADOOP-4053 and HADOOP-4373. This patch fixes that. Contributed by Hemanth Yamijala.
> TestCapacityScheduler is broken
> -------------------------------
>
> Key: HADOOP-4426
> URL: https://issues.apache.org/jira/browse/HADOOP-4426
> Project: Hadoop Core
> Issue Type: Test
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Hemanth Yamijala
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4426.patch
>
>
> The commits for HADOOP-4053 and HADOOP-4373 caused each other's test cases to break. The patches were being worked on in parallel, and hence the break wasn't caught earlier.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.