You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "gitgabrio (via GitHub)" <gi...@apache.org> on 2026/04/02 10:28:18 UTC

[PR] Incubator kie issues#2029 [incubator-kie-kogito-apps]

gitgabrio opened a new pull request, #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317

   Fixes: https://github.com/apache/incubator-kie-issues/issues/2029
   
   Needed by:
   https://github.com/apache/incubator-kie-kogito-examples/pull/2196
   
   Depends on:
   https://github.com/apache/incubator-kie-drools/pull/6633
   https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241
   
   <details>
   <summary>
   How to replicate CI configuration locally?
   </summary>
   
   Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository.
    
   [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it.
   </details>
   
   <details>
   <summary>
   How to retest this PR or trigger a specific build:
   </summary>
   
   - for <b>pull request checks</b>  
     Please add comment: <b>Jenkins retest this</b>
   
   - for a <b>specific pull request check</b>  
     Please add comment: <b>Jenkins (re)run [kogito-apps|kogito-examples] tests</b>
   
   - for <b>quarkus branch checks</b>  
     Run checks against Quarkus current used branch  
     Please add comment: <b>Jenkins run quarkus-branch</b>
   
   - for a <b>quarkus branch specific check</b>  
     Run checks against Quarkus current used branch  
     Please add comment: <b>Jenkins (re)run [kogito-apps|kogito-examples] quarkus-branch</b>
   
   - for <b>quarkus main checks</b>  
     Run checks against Quarkus main branch  
     Please add comment: <b>Jenkins run quarkus-main</b>
   
   - for a <b>specific quarkus main check</b>  
     Run checks against Quarkus main branch  
     Please add comment: <b>Jenkins (re)run [kogito-apps|kogito-examples] quarkus-main</b>
   
   - for <b>quarkus lts checks</b>  
     Run checks against Quarkus lts branch  
     Please add comment: <b>Jenkins run quarkus-lts</b>
   
   - for a <b>specific quarkus lts check</b>  
     Run checks against Quarkus lts branch  
     Please add comment: <b>Jenkins (re)run [kogito-apps|kogito-examples] quarkus-lts</b>
    
   - for <b>native checks</b>  
     Run native checks  
     Please add comment: <b>Jenkins run native</b>
   
   - for a <b>specific native check</b>  
     Run native checks 
     Please add comment: <b>Jenkins (re)run [kogito-apps|kogito-examples] native</b>
   
   - for <b>native lts checks</b>  
     Run native checks against quarkus lts branch
     Please add comment: <b>Jenkins run native-lts</b>
   
   - for a <b>specific native lts check</b>  
     Run native checks against quarkus lts branch
     Please add comment: <b>Jenkins (re)run [kogito-apps|kogito-examples] native-lts</b>
    
   </details>
   
   <details>
   <summary>
   How to backport a pull request to a different branch?
   </summary>
   
   In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-<branch-name>`, where `<branch-name>` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch).
   
   > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.
   
   Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
   
   If something goes wrong, the author will be notified and at this point a manual backporting is needed.
   
   > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
   </details>
   
   <details>
   <summary>
   Quarkus-3 PR check is failing ... what to do ?
   </summary>
   The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.
   
   The first patch, called `0001_before_sh.patch`, is generated from Openrewrite `.ci/environments/quarkus-3/quarkus3.yml` recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.  
   No panic, there is an easy way to regenerate it. You just need to comment on the PR:
   ```
   jenkins rewrite quarkus-3
   ```
   and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.
   
   Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3265012217


##########
trusty/trusty-storage/trusty-storage-infinispan/pom.xml:
##########


Review Comment:
   It is not part of the reactor anymore. It has been removed on 06/27/2025.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3091344082


##########
kogito-apps-springboot/pom.xml:
##########
@@ -0,0 +1,124 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+      http://www.apache.org/licenses/LICENSE-2.0
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied. See the License for the
+    specific language governing permissions and limitations
+    under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.kie.kogito</groupId>
+    <artifactId>kogito-spring-boot-bom</artifactId>
+    <version>999-SNAPSHOT</version>
+    <relativePath/>
+  </parent>
+
+  <artifactId>kogito-apps-springboot</artifactId>

Review Comment:
   @yesamer Sorry, there is not such convention anywhere:
   please look by yourself: springboot and spring-boot are used interchangeable everywhere, and inside kogito-apps it is constantly referred to with "springboot":
   
   (e.g. kogito-runtimes)
   <img width="369" height="95" alt="image" src="https://github.com/user-attachments/assets/e1b10344-b295-4646-83f5-2ec3404ca4e2" />
   
   (e.g. kogito-apps)
   <img width="393" height="170" alt="image" src="https://github.com/user-attachments/assets/cb35a25c-88f5-42e6-a3ca-6e966cd3932b" />
   
   Anyway, I agree that we need to make things consistent, later on (and not only just for the springboot vs spring-boot)
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#issuecomment-4506022483

   > Great work @gitgabrio
   
   😊 Thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3280303803


##########
kogito-apps-springboot/kogito-apps-springboot-bom/pom.xml:
##########
@@ -0,0 +1,145 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+      http://www.apache.org/licenses/LICENSE-2.0
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.kie.kogito</groupId>
+    <artifactId>kogito-apps-springboot</artifactId>
+    <version>999-SNAPSHOT</version>
+  </parent>
+
+  <artifactId>kogito-apps-springboot-bom</artifactId>

Review Comment:
   @pefernan 
   This has been already mentioned. Point is, that there is not a single "convention" about springboot naming, for the moment being. You may verify by yourself in that very repo: look for "springboot" and "spring-boot" all over poms.
   I agree to refactor that later on, but for the moment being I would prefer to avoid introducing unnecessary potential breaking changes: does this make sense ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio merged PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "pefernan (via GitHub)" <gi...@apache.org>.
pefernan commented on PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#issuecomment-4500354793

   @gitgabrio thanks massive effort! 
   why not having `data-index-service-common`, `data-index-storage-quarkus`  & `data-index-test-utils-quarkus` inside `kogito-apps-quarkus/data-index-quarkus`?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086528704


##########
trusty/trusty-storage/trusty-storage-redis/pom.xml:
##########
@@ -22,18 +22,20 @@
 <project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xmlns="http://maven.apache.org/POM/4.0.0"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
   <parent>
-    <artifactId>trusty-storage</artifactId>
     <groupId>org.kie.kogito</groupId>
+    <artifactId>trusty-storage</artifactId>
     <version>999-SNAPSHOT</version>
   </parent>
-  <modelVersion>4.0.0</modelVersion>
 
   <artifactId>trusty-storage-redis</artifactId>
   <name>Kogito Apps :: Trusty Storage Redis</name>
 
   <properties>
     <java.module.name>org.kie.kogito.trusty.storage.redis</java.module.name>
+    <disable.quarkus.jar.rename>false</disable.quarkus.jar.rename>
+    <disable.quarkus.plugin>true</disable.quarkus.plugin>

Review Comment:
   @yesamer 
   With this PR, the quarkus plugin configuration is inherited everywhere from quarkus parent bom.
   Those two properties are needed to:
   
   1. enable/disable the jar renaming
   2. enable/disable the plugin itself (there are quarkus modules, like this one, inside which the quarkus plugin should not be executed). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086607651


##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
     @InjectMock
     TrustyService trustyService;
 
-    @Test
+    /* @Test */
     void shouldReturnUnauthorized() {
         given().get(TRUSTY_ENDPOINT)
                 .then().statusCode(HttpStatus.SC_UNAUTHORIZED);
     }
 
-    @Test
+    /* @Test */

Review Comment:
   Yes, since those are broken, I can't understand why, and AFAIK there  is no one who maintain this code and knows what was the logic behind



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086604919


##########
trusty/trusty-storage/trusty-storage-infinispan/pom.xml:
##########
@@ -1,77 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
-    Licensed to the Apache Software Foundation (ASF) under one
-    or more contributor license agreements.  See the NOTICE file
-    distributed with this work for additional information
-    regarding copyright ownership.  The ASF licenses this file
-    to you under the Apache License, Version 2.0 (the
-    "License"); you may not use this file except in compliance
-    with the License.  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-    Unless required by applicable law or agreed to in writing,
-    software distributed under the License is distributed on an
-    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-    KIND, either express or implied.  See the License for the
-    specific language governing permissions and limitations
-    under the License.
-
--->
-<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xmlns="http://maven.apache.org/POM/4.0.0"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-  <parent>
-    <artifactId>trusty-storage</artifactId>
-    <groupId>org.kie.kogito</groupId>
-    <version>999-SNAPSHOT</version>
-  </parent>
-  <modelVersion>4.0.0</modelVersion>
-
-  <artifactId>trusty-storage-infinispan</artifactId>

Review Comment:
   I restored.
   Anyway, it is excluded from normal reactor 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086544359


##########
trusty/trusty-storage/trusty-storage-infinispan/pom.xml:
##########
@@ -1,77 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
-    Licensed to the Apache Software Foundation (ASF) under one
-    or more contributor license agreements.  See the NOTICE file
-    distributed with this work for additional information
-    regarding copyright ownership.  The ASF licenses this file
-    to you under the Apache License, Version 2.0 (the
-    "License"); you may not use this file except in compliance
-    with the License.  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-    Unless required by applicable law or agreed to in writing,
-    software distributed under the License is distributed on an
-    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-    KIND, either express or implied.  See the License for the
-    specific language governing permissions and limitations
-    under the License.
-
--->
-<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xmlns="http://maven.apache.org/POM/4.0.0"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-  <parent>
-    <artifactId>trusty-storage</artifactId>
-    <groupId>org.kie.kogito</groupId>
-    <version>999-SNAPSHOT</version>
-  </parent>
-  <modelVersion>4.0.0</modelVersion>
-
-  <artifactId>trusty-storage-infinispan</artifactId>

Review Comment:
   IIRC, this has been introduced by a PR from Alex



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3265029015


##########
trusty/trusty-service/trusty-service-postgresql/pom.xml:
##########
@@ -88,38 +91,4 @@
       <scope>test</scope>
     </dependency>
   </dependencies>
-
-  <build>
-    <plugins>
-      <plugin>
-        <groupId>io.quarkus</groupId>
-        <artifactId>quarkus-maven-plugin</artifactId>

Review Comment:
   Now it inherit the quarkus-maven-plugin configuration, tweaking it with the following variables:
   
   ```xml
    <disable.quarkus.jar.rename>false</disable.quarkus.jar.rename>
       <disable.quarkus.plugin>false</disable.quarkus.plugin>
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3264831676


##########
apps-integration-tests/integration-tests-trusty-service/integration-tests-trusty-service-common/src/main/java/org/kie/kogito/it/trusty/AbstractTrustyExplainabilityEnd2EndIT.java:
##########


Review Comment:
   They are not part of the reactor anymore. They have been removed on 06/27/2025.
   I'll restore them in proper place, but keep them disabled



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#issuecomment-4506129251

   > @gitgabrio thanks massive effort! why not having `data-index-service-common`, `data-index-storage-quarkus` & `data-index-test-utils-quarkus` inside `kogito-apps-quarkus/data-index-quarkus`?
   
   When I've done that I preserved the original structure, more or less, to limit as much as possible "parent" changes.
   Anyway, it is an improvement that could be done later on, also in the springboot counterpart, with your help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3280303803


##########
kogito-apps-springboot/kogito-apps-springboot-bom/pom.xml:
##########
@@ -0,0 +1,145 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+      http://www.apache.org/licenses/LICENSE-2.0
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.kie.kogito</groupId>
+    <artifactId>kogito-apps-springboot</artifactId>
+    <version>999-SNAPSHOT</version>
+  </parent>
+
+  <artifactId>kogito-apps-springboot-bom</artifactId>

Review Comment:
   @pefernan 
   This has been already mentioned. Point is, that there is not a single "convention" about springboot naming, for the moment being. You may verify by yourself in that very repo: lok for "springboot" and "spring-boot" all over poms.
   I agree to refactor that later on, but for the moment being I would prefer to avoid introducing unnecessary potential breaking changes: does this make sense ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086544359


##########
trusty/trusty-storage/trusty-storage-infinispan/pom.xml:
##########
@@ -1,77 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
-    Licensed to the Apache Software Foundation (ASF) under one
-    or more contributor license agreements.  See the NOTICE file
-    distributed with this work for additional information
-    regarding copyright ownership.  The ASF licenses this file
-    to you under the Apache License, Version 2.0 (the
-    "License"); you may not use this file except in compliance
-    with the License.  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-    Unless required by applicable law or agreed to in writing,
-    software distributed under the License is distributed on an
-    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-    KIND, either express or implied.  See the License for the
-    specific language governing permissions and limitations
-    under the License.
-
--->
-<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xmlns="http://maven.apache.org/POM/4.0.0"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-  <parent>
-    <artifactId>trusty-storage</artifactId>
-    <groupId>org.kie.kogito</groupId>
-    <version>999-SNAPSHOT</version>
-  </parent>
-  <modelVersion>4.0.0</modelVersion>
-
-  <artifactId>trusty-storage-infinispan</artifactId>

Review Comment:
   IIRC, this has been introduced by a PR from Alex



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086637784


##########
persistence-commons/persistence-commons-mongodb/pom.xml:
##########
@@ -34,8 +34,20 @@
 
   <properties>
     <java.module.name>org.kie.kogito.persistence.mongodb</java.module.name>
+    <version.mongodb-driver-sync>5.5.1</version.mongodb-driver-sync>

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]

Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3087479732


##########
kogito-apps-springboot/pom.xml:
##########
@@ -0,0 +1,124 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+      http://www.apache.org/licenses/LICENSE-2.0
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied. See the License for the
+    specific language governing permissions and limitations
+    under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.kie.kogito</groupId>
+    <artifactId>kogito-spring-boot-bom</artifactId>
+    <version>999-SNAPSHOT</version>
+    <relativePath/>
+  </parent>
+
+  <artifactId>kogito-apps-springboot</artifactId>

Review Comment:
   @gitgabrio Please use the same convention we have in kogito runtime (`kogito-apps-spring-boot`)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "martinweiler (via GitHub)" <gi...@apache.org>.
martinweiler commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3275583861


##########
explainability/explainability-service-rest/src/test/java/org/kie/kogito/explainability/rest/KeycloakExplainabilityServiceIT.java:
##########
@@ -19,19 +19,21 @@
 package org.kie.kogito.explainability.rest;
 
 import org.apache.http.HttpStatus;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Disabled;
 import org.kie.kogito.test.quarkus.QuarkusTestProperty;
 import org.kie.kogito.testcontainers.KogitoKeycloakContainer;
 import org.kie.kogito.testcontainers.quarkus.KeycloakQuarkusTestResource;
 
-import io.quarkus.test.common.QuarkusTestResource;
-import io.quarkus.test.junit.QuarkusTest;
 import io.restassured.RestAssured;
 
 import static io.restassured.RestAssured.given;
 
-@QuarkusTest
-@QuarkusTestResource(KeycloakQuarkusTestResource.Conditional.class)
+/*@QuarkusTest
+@QuarkusTestResource(KeycloakQuarkusTestResource.Conditional.class)*/
+@Disabled("Currently disabled due to failures on test instantiation. For some reason, the KogitoKeycloakContainer" +
+        ".getMappedPort() is invoked before" +
+        "the container is up and running, hence it throws an IllegalStateException. This needs to be investigated and" +
+        " fixed before re-enabling the test.")

Review Comment:
   This needs a follow-up tracker to investigate further and re-enable the test eventually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3261469271


##########
trusty/trusty-storage/trusty-storage-infinispan/pom.xml:
##########


Review Comment:
   @gitgabrio I'm aware there is an ongoing initiative to remove infinispan support, is this module removal related to that? 



##########
apps-integration-tests/integration-tests-trusty-service/integration-tests-trusty-service-common/src/main/java/org/kie/kogito/it/trusty/AbstractTrustyExplainabilityEnd2EndIT.java:
##########


Review Comment:
   @gitgabrio Was the integration-tests-trusty-service-common intentionally removed? Why?



##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
     @InjectMock
     TrustyService trustyService;
 
-    @Test
+    /* @Test */
     void shouldReturnUnauthorized() {
         given().get(TRUSTY_ENDPOINT)
                 .then().statusCode(HttpStatus.SC_UNAUTHORIZED);
     }
 
-    @Test
+    /* @Test */

Review Comment:
   @gitgabrio As you disabled the entire Class, I guess you can remove the comment.



##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
     @InjectMock
     TrustyService trustyService;
 
-    @Test
+    /* @Test */

Review Comment:
   @gitgabrio As you disabled the entire Class, I guess you can remove the comment.



##########
trusty/trusty-service/trusty-service-postgresql/pom.xml:
##########
@@ -88,38 +91,4 @@
       <scope>test</scope>
     </dependency>
   </dependencies>
-
-  <build>
-    <plugins>
-      <plugin>
-        <groupId>io.quarkus</groupId>
-        <artifactId>quarkus-maven-plugin</artifactId>

Review Comment:
   @gitgabrio Can you please clarify the trusty-module module management? It previously was a quarkus app and now in no longer that? 



##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
     @InjectMock
     TrustyService trustyService;
 
-    @Test
+    /* @Test */
     void shouldReturnUnauthorized() {
         given().get(TRUSTY_ENDPOINT)
                 .then().statusCode(HttpStatus.SC_UNAUTHORIZED);
     }
 
-    @Test
+    /* @Test */
     void shouldReturnOkWhenValidUser() {
-        when(trustyService.getExecutionHeaders(any(OffsetDateTime.class), any(OffsetDateTime.class), anyInt(), anyInt(), anyString())).thenReturn(new MatchedExecutionHeaders(new ArrayList<>(), 0));
+        when(trustyService.getExecutionHeaders(any(OffsetDateTime.class), any(OffsetDateTime.class), anyInt(),
+                anyInt(), anyString())).thenReturn(new MatchedExecutionHeaders(new ArrayList<>(), 0));

Review Comment:
   I guess this line change is useless



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]

Posted by "pefernan (via GitHub)" <gi...@apache.org>.
pefernan commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3280277216


##########
kogito-apps-springboot/kogito-apps-springboot-bom/pom.xml:
##########
@@ -0,0 +1,145 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+      http://www.apache.org/licenses/LICENSE-2.0
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.kie.kogito</groupId>
+    <artifactId>kogito-apps-springboot</artifactId>
+    <version>999-SNAPSHOT</version>
+  </parent>
+
+  <artifactId>kogito-apps-springboot-bom</artifactId>

Review Comment:
   @gitgabrio just nip picking, but I see that in runtimes the bom is called `kogito-spring-boot-bom` while here `kogito-apps-springboot-bom` I think we should be consistent with the artifact Id.
   
   
   
   ```suggestion
     <artifactId>kogito-apps-spring-boot-bom</artifactId>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086607651


##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
     @InjectMock
     TrustyService trustyService;
 
-    @Test
+    /* @Test */
     void shouldReturnUnauthorized() {
         given().get(TRUSTY_ENDPOINT)
                 .then().statusCode(HttpStatus.SC_UNAUTHORIZED);
     }
 
-    @Test
+    /* @Test */

Review Comment:
   Yes, since those are broken and I can't understand why



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]

Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #2317:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086446448


##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
     @InjectMock
     TrustyService trustyService;
 
-    @Test
+    /* @Test */
     void shouldReturnUnauthorized() {
         given().get(TRUSTY_ENDPOINT)
                 .then().statusCode(HttpStatus.SC_UNAUTHORIZED);
     }
 
-    @Test
+    /* @Test */

Review Comment:
   @gitgabrio Are those temporarily disabled?



##########
trusty/trusty-storage/trusty-storage-redis/pom.xml:
##########
@@ -22,18 +22,20 @@
 <project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xmlns="http://maven.apache.org/POM/4.0.0"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
   <parent>
-    <artifactId>trusty-storage</artifactId>
     <groupId>org.kie.kogito</groupId>
+    <artifactId>trusty-storage</artifactId>
     <version>999-SNAPSHOT</version>
   </parent>
-  <modelVersion>4.0.0</modelVersion>
 
   <artifactId>trusty-storage-redis</artifactId>
   <name>Kogito Apps :: Trusty Storage Redis</name>
 
   <properties>
     <java.module.name>org.kie.kogito.trusty.storage.redis</java.module.name>
+    <disable.quarkus.jar.rename>false</disable.quarkus.jar.rename>
+    <disable.quarkus.plugin>true</disable.quarkus.plugin>

Review Comment:
   @gitgabrio Can you please explain those additions?



##########
trusty/trusty-storage/trusty-storage-infinispan/pom.xml:
##########
@@ -1,77 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
-    Licensed to the Apache Software Foundation (ASF) under one
-    or more contributor license agreements.  See the NOTICE file
-    distributed with this work for additional information
-    regarding copyright ownership.  The ASF licenses this file
-    to you under the Apache License, Version 2.0 (the
-    "License"); you may not use this file except in compliance
-    with the License.  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-    Unless required by applicable law or agreed to in writing,
-    software distributed under the License is distributed on an
-    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-    KIND, either express or implied.  See the License for the
-    specific language governing permissions and limitations
-    under the License.
-
--->
-<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xmlns="http://maven.apache.org/POM/4.0.0"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-  <parent>
-    <artifactId>trusty-storage</artifactId>
-    <groupId>org.kie.kogito</groupId>
-    <version>999-SNAPSHOT</version>
-  </parent>
-  <modelVersion>4.0.0</modelVersion>
-
-  <artifactId>trusty-storage-infinispan</artifactId>

Review Comment:
   @gitgabrio If I understood correctly, are we removing this module entirely?



##########
persistence-commons/persistence-commons-mongodb/pom.xml:
##########
@@ -34,8 +34,20 @@
 
   <properties>
     <java.module.name>org.kie.kogito.persistence.mongodb</java.module.name>
+    <version.mongodb-driver-sync>5.5.1</version.mongodb-driver-sync>

Review Comment:
   @gitgabrio Don't we have a "global" mongodb declaration?



##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
     @InjectMock
     TrustyService trustyService;
 
-    @Test
+    /* @Test */

Review Comment:
   @gitgabrio Are those temporarily disabled?



##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -22,28 +22,28 @@
 import java.util.ArrayList;
 
 import org.apache.http.HttpStatus;
-import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.api.Disabled;
 import org.kie.kogito.test.quarkus.QuarkusTestProperty;
 import org.kie.kogito.testcontainers.KogitoKeycloakContainer;
 import org.kie.kogito.testcontainers.quarkus.KeycloakQuarkusTestResource;
 import org.kie.kogito.trusty.service.common.models.MatchedExecutionHeaders;
 
 import io.quarkus.test.InjectMock;
-import io.quarkus.test.common.QuarkusTestResource;
-import io.quarkus.test.common.ResourceArg;
-import io.quarkus.test.junit.QuarkusTest;
 
 import static io.restassured.RestAssured.given;
-import static org.kie.kogito.testcontainers.quarkus.KeycloakQuarkusTestResource.KOGITO_OIDC_TENANTS;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.anyInt;
 import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.Mockito.when;
 
-@QuarkusTest
-@QuarkusTestResource(value = KeycloakQuarkusTestResource.class, initArgs = { @ResourceArg(name = KOGITO_OIDC_TENANTS, value = "web-app-tenant") })
-@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+/*@QuarkusTest
+@QuarkusTestResource(value = KeycloakQuarkusTestResource.class, initArgs = { @ResourceArg(name = KOGITO_OIDC_TENANTS,

Review Comment:
   @gitgabrio Are those temporarily disabled?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org