You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/18 13:18:35 UTC
[GitHub] [flink] AHeise opened a new pull request #11123: [FLINK-16014]
Adding xerces to s3 plugins to avoid ClassNotFound issues.
AHeise opened a new pull request #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Adding xerces to s3 plugins to avoid ClassNotFound issues.
Root cause is a [bug](https://bugs.openjdk.java.net/browse/JDK-8015099) in JDK8. `XMLReaderFactory` caches the class name independent of the classloader. On EMR, xercesImpl is on classpath (because of HDFS) and will be loaded at some point in time.
Also overwriting the faulty `XMLReaderFactory` in the plugins with a non-caching implementation that only loads the bundled xerces.
## Brief change log
- Adding xerces to s3 plugins
- Overwriting the faulty `XMLReaderFactory` in the plugins with a non-caching implementation that only loads the bundled xerces.
## Verifying this change
Manually tested on EMR.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (**yes** / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #11123: [FLINK-16014] Adding
xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-588755835
In JDK-8015099 a workaround was suggested to use `SAXParserFactory` instead. Have you looked into this as a potential solution?
What we could try is bundling an alternative version of the aws `XmlResponsesSaxParser` class which calls `SAXParserFactory.newSAXParser().getXMLReader()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123: [FLINK-16014]
Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149450144 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
-->
## CI report:
* 83b98e39b163308ede9d79d2f905d6c12f23203b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149450144) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r387572783
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -231,6 +231,33 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
it would be safer to move this into the presto/hadoop modules; as it stands you're excluding one dependency (and kicking out a transitive one), with downstream modules not being aware that this module is bundling anything and hence also trying to bundle `aws-java-sdk-s3`.
This is the warning you get when building downstream modules:
```
[WARNING] flink-s3-fs-base-1.11-SNAPSHOT.jar, aws-java-sdk-s3-1.11.271.jar define 29 overlapping classes:
[WARNING] - com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$GetObjectTaggingHandler
[WARNING] - com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$ListPartsHandler
[WARNING] - com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$BucketLocationHandler
[WARNING] - com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$ListVersionsHandler
[WARNING] - com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$ListAllMyBucketsHandler
[WARNING] - com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$ListBucketInventoryConfigurationsHandler
[WARNING] - com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$ListBucketHandler
[WARNING] - com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$AccessControlListHandler
[WARNING] - com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$InitiateMultipartUploadHandler
[WARNING] - com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$GetBucketInventoryConfigurationHandler
[WARNING] - 19 more...
```
As it stands this will require duplicating things; it would've easier if the S3 filesystems where organized in a hierarchy such that we could use inheritance for this stuff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151954486",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d28892370884e69d1dfa550c69fd664d0053fdd Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151954486) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123: [FLINK-16014]
Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149450144 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
-->
## CI report:
* 83b98e39b163308ede9d79d2f905d6c12f23203b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149450144) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b18e6f5ff641afd27cfeccb5236a52f1e844498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151044398) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748)
* 05703e66f5eeb89e476145d40538684c0926908d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 128a485e9c65cb7b24f5e48400ff830af16ff620 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150841683)
* 3b18e6f5ff641afd27cfeccb5236a52f1e844498 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r387589862
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -231,6 +231,33 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
I will try to pursuit the hierarchy approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise edited a comment on issue #11123: [FLINK-16014]
Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
AHeise edited a comment on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-588790296
> In JDK-8015099 a workaround was suggested to use `SAXParserFactory` instead. Have you looked into this as a potential solution?
> What we could try is bundling an alternative version of the aws `XmlResponsesSaxParser` class which calls `SAXParserFactory.newSAXParser().getXMLReader()`.
That's also a valid solution but I'm not sure which is less hacky. You probably suggest it, such that we avoid bundling xerces?
How often would we update AWS sdk or a user would build against a different hadoop version, such that our `XmlResponsesSaxParser` becomes fragile?
@zentol @pnowojski WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151954486",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d28892370884e69d1dfa550c69fd664d0053fdd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151954486) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971)
* bd9da339fdfee9967e478154bf127976b7a333b5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 95e457e1d10f8c7b0de7e52fef42f6ac029912a6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151711705) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912)
* 3d28892370884e69d1dfa550c69fd664d0053fdd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #11123: [FLINK-16014][s3] Force
usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-592556546
Added shading exclusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #11123: [FLINK-16014][s3] Force
usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11123:
[FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#discussion_r381843042
##########
File path: flink-filesystems/flink-s3-fs-hadoop/src/main/resources/META-INF/NOTICE
##########
@@ -31,6 +31,7 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.httpcomponents:httpcore:4.4.6
- org.apache.httpcomponents:httpclient:4.5.3
- software.amazon.ion:ion-java:1.0.2
+- xerces:xercesImpl:2.12.0
Review comment:
are we not also bundling `xml-apis:xml-apis`, a transitive dependency of xercesImpl?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11123:
[FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#discussion_r380691609
##########
File path: flink-filesystems/flink-s3-fs-base/src/main/java/org/xml/sax/helpers/XMLReaderFactory.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.xml.sax.helpers;
+
+import org.apache.xerces.jaxp.SAXParserFactoryImpl;
+import org.xml.sax.SAXException;
+import org.xml.sax.XMLReader;
+
+import javax.xml.parsers.ParserConfigurationException;
+import javax.xml.parsers.SAXParserFactory;
+
+/**
+ * Workaround for JDK-8015099, this factory always provides a bundled xerces parser for plugins.
+ *
+ * <p>Will provide a proper isolation for all kinds of different setups (other sax parser in lib or bundled in user
+ * code).
+ */
+public class XMLReaderFactory {
Review comment:
add a note that this can be removed once Java8 support is dropped?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 128a485e9c65cb7b24f5e48400ff830af16ff620 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150841683)
* 3b18e6f5ff641afd27cfeccb5236a52f1e844498 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151044398)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #11123: [FLINK-16014][s3] Force
usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-595398912
Added shade filter also to two subprojects. [Azure](https://dev.azure.com/rmetzger/Flink/_build/results?buildId=5980&view=results) is now green (no clue why it doesn't show) and I don't see the warnings in the logs anymore.
@zentol if you could point me to a way to use a parent pom without a new module, I'd go for it. If not, then I'd say the current solution should suffice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123: [FLINK-16014]
Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83b98e39b163308ede9d79d2f905d6c12f23203b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149450144) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279)
* 385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149639586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151954486",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151981521",
"triggerID" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"triggerType" : "PUSH"
}, {
"hash" : "86c767d21b0e1b49e068fb086741776aa7d56b3e",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152184987",
"triggerID" : "86c767d21b0e1b49e068fb086741776aa7d56b3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86c767d21b0e1b49e068fb086741776aa7d56b3e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152184987)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #11123: [FLINK-16014] Adding
xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-588231200
Addressed comments by @zentol .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123: [FLINK-16014]
Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149450144 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
-->
## CI report:
* 83b98e39b163308ede9d79d2f905d6c12f23203b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149450144) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 95e457e1d10f8c7b0de7e52fef42f6ac029912a6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151711705) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123: [FLINK-16014]
Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149450144 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
Hash:385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2
-->
## CI report:
* 83b98e39b163308ede9d79d2f905d6c12f23203b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149450144) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279)
* 385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise removed a comment on issue #11123: [FLINK-16014][s3]
Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
AHeise removed a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-588790296
> In JDK-8015099 a workaround was suggested to use `SAXParserFactory` instead. Have you looked into this as a potential solution?
> What we could try is bundling an alternative version of the aws `XmlResponsesSaxParser` class which calls `SAXParserFactory.newSAXParser().getXMLReader()`.
That's also a valid solution but I'm not sure which is less hacky. You probably suggest it, such that we avoid bundling xerces?
How often would we update AWS sdk or a user would build against a different hadoop version, such that our `XmlResponsesSaxParser` becomes fragile?
@zentol @pnowojski WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151954486",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151981521",
"triggerID" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"triggerType" : "PUSH"
}, {
"hash" : "86c767d21b0e1b49e068fb086741776aa7d56b3e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86c767d21b0e1b49e068fb086741776aa7d56b3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd9da339fdfee9967e478154bf127976b7a333b5 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151981521)
* 86c767d21b0e1b49e068fb086741776aa7d56b3e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151954486",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151981521",
"triggerID" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd9da339fdfee9967e478154bf127976b7a333b5 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151981521)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151954486",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 95e457e1d10f8c7b0de7e52fef42f6ac029912a6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151711705) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912)
* 3d28892370884e69d1dfa550c69fd664d0053fdd Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151954486) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b18e6f5ff641afd27cfeccb5236a52f1e844498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151044398) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748)
* 05703e66f5eeb89e476145d40538684c0926908d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151688123)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r388868454
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -231,6 +231,33 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <filters>
+ <filter>
+ <artifact>com.amazonaws:aws-java-sdk-s3</artifact>
Review comment:
this should no longer be necessary since `flink-s3-fs-base` no longer bundles this dependency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11123:
[FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#discussion_r380691573
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -204,6 +204,11 @@ under the License.
<artifactId>aws-java-sdk-dynamodb</artifactId>
<version>${fs.s3.aws.version}</version>
</dependency>
+ <dependency>
+ <groupId>xerces</groupId>
+ <artifactId>xercesImpl</artifactId>
Review comment:
add a note that this can be removed once Java8 support is dropped?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149639586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321)
* 128a485e9c65cb7b24f5e48400ff830af16ff620 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r388868052
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -231,6 +231,33 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
I forgot that S3 base contains code, ignore the suggestion about parent modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 128a485e9c65cb7b24f5e48400ff830af16ff620 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150841683)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r388360213
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -231,6 +231,33 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
it doesn't have to ship code; you can define the shade plugin configuration in the parent, which is then inherited by the child modules, which then do the inclusion/exclusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b18e6f5ff641afd27cfeccb5236a52f1e844498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151044398) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b18e6f5ff641afd27cfeccb5236a52f1e844498 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151044398) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r389631039
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -231,6 +231,33 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <filters>
+ <filter>
+ <artifact>com.amazonaws:aws-java-sdk-s3</artifact>
Review comment:
Good catch. Not sure why I thought it was necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123: [FLINK-16014]
Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149450144 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
Hash:385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149639586 TriggerType:PUSH TriggerID:385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2
Hash:385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321 TriggerType:PUSH TriggerID:385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2
-->
## CI report:
* 83b98e39b163308ede9d79d2f905d6c12f23203b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149450144) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279)
* 385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149639586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149639586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321)
* 128a485e9c65cb7b24f5e48400ff830af16ff620 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150841683)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151954486",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d28892370884e69d1dfa550c69fd664d0053fdd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151954486) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #11123: [FLINK-16014] Adding
xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-588790296
> In JDK-8015099 a workaround was suggested to use `SAXParserFactory` instead. Have you looked into this as a potential solution?
> What we could try is bundling an alternative version of the aws `XmlResponsesSaxParser` class which calls `SAXParserFactory.newSAXParser().getXMLReader()`.
That's also a valid solution but I'm not sure which is less hacky. You probably suggest it, such that we avoid bundling xerces?
How often would we update AWS sdk or a user would build against a different hadoop version, such that our `XmlResponsesSaxParser` becomes fragile?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #11123: [FLINK-16014][s3] Force
usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-596498832
Green @ [azure](https://dev.azure.com/rmetzger/Flink/_build/results?buildId=6030&view=results) and travis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #11123: [FLINK-16014][s3] Force
usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-591978948
> In JDK-8015099 a workaround was suggested to use `SAXParserFactory` instead. Have you looked into this as a potential solution?
> What we could try is bundling an alternative version of the aws `XmlResponsesSaxParser` class which calls `SAXParserFactory.newSAXParser().getXMLReader()`.
I used exactly that approach now.
My previous approach never worked as intended as the current PluginClassLoader does not allow to overwrite a system class through plugin classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r388503914
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -231,6 +231,33 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
Not sure what you mean but `flink-s3-fs-base` has code that is lost when I change packaging to `pom`, which in turn is required for parent projects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r386345138
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -231,6 +231,30 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <filters>
+ <filter>
+ <artifact>com.amazonaws:aws-java-sdk-s3</artifact>
+ <excludes>
+ <exclude>com/amazonaws/services/s3/model/transform/XmlResponsesSaxParser**</exclude>
Review comment:
add a comment for why this is done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11123: [FLINK-16014] Adding
xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
-->
## CI report:
* 83b98e39b163308ede9d79d2f905d6c12f23203b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05703e66f5eeb89e476145d40538684c0926908d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151688123) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898)
* 95e457e1d10f8c7b0de7e52fef42f6ac029912a6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05703e66f5eeb89e476145d40538684c0926908d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151688123) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 95e457e1d10f8c7b0de7e52fef42f6ac029912a6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151711705) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151954486",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151981521",
"triggerID" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d28892370884e69d1dfa550c69fd664d0053fdd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151954486) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971)
* bd9da339fdfee9967e478154bf127976b7a333b5 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151981521)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11123: [FLINK-16014] Adding
xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587456593
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 83b98e39b163308ede9d79d2f905d6c12f23203b (Tue Feb 18 13:20:41 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16014).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150841683",
"triggerID" : "128a485e9c65cb7b24f5e48400ff830af16ff620",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151044398",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5748",
"triggerID" : "3b18e6f5ff641afd27cfeccb5236a52f1e844498",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151688123",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "05703e66f5eeb89e476145d40538684c0926908d",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5898",
"triggerID" : "05703e66f5eeb89e476145d40538684c0926908d",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5912",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151711705",
"triggerID" : "95e457e1d10f8c7b0de7e52fef42f6ac029912a6",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5971",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151954486",
"triggerID" : "3d28892370884e69d1dfa550c69fd664d0053fdd",
"triggerType" : "PUSH"
}, {
"hash" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151981521",
"triggerID" : "bd9da339fdfee9967e478154bf127976b7a333b5",
"triggerType" : "PUSH"
}, {
"hash" : "86c767d21b0e1b49e068fb086741776aa7d56b3e",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152184987",
"triggerID" : "86c767d21b0e1b49e068fb086741776aa7d56b3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd9da339fdfee9967e478154bf127976b7a333b5 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151981521)
* 86c767d21b0e1b49e068fb086741776aa7d56b3e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/152184987)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587456593
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3b18e6f5ff641afd27cfeccb5236a52f1e844498 (Fri Feb 28 21:50:04 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123: [FLINK-16014]
Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
Hash:83b98e39b163308ede9d79d2f905d6c12f23203b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149450144 TriggerType:PUSH TriggerID:83b98e39b163308ede9d79d2f905d6c12f23203b
Hash:385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149639586 TriggerType:PUSH TriggerID:385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2
-->
## CI report:
* 83b98e39b163308ede9d79d2f905d6c12f23203b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149450144) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279)
* 385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149639586)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #11123:
[FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in
aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r387881168
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -231,6 +231,33 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
Unfortunately, it's not that easy. If it's a parent project, it needs to be of type pom and cannot ship code by default.
There is a [workaround](https://stackoverflow.com/questions/12305190/how-to-generate-jar-for-maven-parent-project), but it's certainly adding some complexity.
The cleanest solution would be to add another module just for the pom, but that's also more complex than I'd like it to be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11123: [FLINK-16014]
Adding xerces to s3 plugins to avoid ClassNotFound issues.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11123: [FLINK-16014] Adding xerces to s3 plugins to avoid ClassNotFound issues.
URL: https://github.com/apache/flink/pull/11123#issuecomment-587468233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5279",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149450144",
"triggerID" : "83b98e39b163308ede9d79d2f905d6c12f23203b",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149639586",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
}, {
"hash" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321",
"triggerID" : "385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 385ebf4f1ad02ea7a62b2f6fadd54cd1fa6121e2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149639586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5321)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #11123: [FLINK-16014][s3] Force
usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #11123: [FLINK-16014][s3] Force usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#issuecomment-592548069
Opened ticket https://github.com/aws/aws-sdk-java/issues/2242 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services