[GitHub] [airflow] blag commented on a diff in pull request #25419: Create a pluggable DatasetEventManager

[GitBox <gi...@apache.org>]

blag commented on code in PR #25419:
URL: https://github.com/apache/airflow/pull/25419#discussion_r948668071


##########
airflow/datasets/manager.py:
##########
@@ -0,0 +1,64 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from sqlalchemy.orm.session import Session
+
+from airflow.models.dataset import DatasetDagRunQueue, DatasetEvent
+from airflow.utils.log.logging_mixin import LoggingMixin
+from airflow.utils.session import NEW_SESSION
+
+
+class DatasetEventManager(LoggingMixin):
+    """
+    A pluggable class that manages operations for dataset events.
+
+    The intent is to have one place to handle all DatasetEvent-related operations, so different
+    Airflow deployments can use plugins that broadcast dataset events to each other.
+    """
+
+    def register_dataset_change(
+        self, *, task_instance=None, dataset=None, extra=None, session: Session = NEW_SESSION
+    ) -> None:
+        """
+        For local datasets, look them up, record the dataset event, queue dagruns, and broadcast
+        the dataset event
+        """
+        from airflow.datasets import Dataset
+        from airflow.models.dataset import DatasetModel
+
+        if isinstance(dataset, Dataset):
+            dataset = session.query(DatasetModel).filter(DatasetModel.uri == dataset.uri).one_or_none()
+            if not dataset:
+                self.log.warning("Dataset %s not found", dataset)
+                return
+        session.add(
+            DatasetEvent(
+                dataset_id=dataset.id,
+                source_task_id=task_instance.task_id,
+                source_dag_id=task_instance.dag_id,
+                source_run_id=task_instance.run_id,
+                source_map_index=task_instance.map_index,
+                extra=extra,
+            )
+        )

Review Comment:
   Nope, I caught those and I'm actually working on tests for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org