[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #909: Parquet: Support constant map for partition values

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #909: Parquet: Support constant map for partition values
URL: https://github.com/apache/incubator-iceberg/pull/909#discussion_r406461875
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/avro/ValueReaders.java
 ##########
 @@ -597,10 +595,6 @@ protected StructReader(List<ValueReader<?>> readers, Types.StructType struct, Ma
 
     protected abstract void set(S struct, int pos, Object value);
 
-    protected Object prepareConstant(Type type, Object value) {
 
 Review comment:
   I'm moving this out of Avro and adding a callback to convert the constants to `PartitionUtil.constantsMap`. That way, Spark can supply a conversion function and use it in both places, instead of duplicating the conversion in Avro and Parquet readers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org