You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zddr (via GitHub)" <gi...@apache.org> on 2023/06/16 12:47:09 UTC
[GitHub] [doris] zddr opened a new pull request, #20926: [feature](fs)add fs_s3 benchmark tool
zddr opened a new pull request, #20926:
URL: https://github.com/apache/doris/pull/20926
## Proposed changes
Issue Number: close #xxx
add fs_s3 benchmark tool
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1608807632
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature](fs)add fs_s3 benchmark tool
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1605295352
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1612902015
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #20926:
URL: https://github.com/apache/doris/pull/20926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature](fs)add fs_s3 benchmark tool
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1600311367
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] gavinchou commented on a diff in pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #20926:
URL: https://github.com/apache/doris/pull/20926#discussion_r1243148303
##########
be/src/runtime/exec_env.h:
##########
@@ -185,6 +185,9 @@ class ExecEnv {
void set_stream_load_executor(std::shared_ptr<StreamLoadExecutor> stream_load_executor) {
this->_stream_load_executor = stream_load_executor;
}
+ void set_buffered_reader_prefetch_thread_pool(ThreadPool* thread_pool) {
Review Comment:
Is this function referenced somewhere?
##########
be/src/service/doris_main.cpp:
##########
@@ -432,6 +433,12 @@ int main(int argc, char** argv) {
doris::ExecEnv::init(exec_env, paths);
doris::TabletSchemaCache::create_global_schema_cache();
+ // init s3 write buffer pool
+ doris::io::S3FileBufferPool* s3_buffer_pool = doris::io::S3FileBufferPool::GetInstance();
+ s3_buffer_pool->init(doris::config::s3_write_buffer_whole_size,
+ doris::config::s3_write_buffer_size,
+ exec_env->buffered_reader_prefetch_thread_pool());
Review Comment:
Is it intent to reuse the "reader thread pool"?
It seems not a good idea. I suggest making them isolated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature](fs)add fs_s3 benchmark tool
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1605295370
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature](fs)add fs_s3 benchmark tool
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1606756043
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] kaka11chen commented on pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1611610247
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #20926:
URL: https://github.com/apache/doris/pull/20926#discussion_r1243224061
##########
be/src/service/doris_main.cpp:
##########
@@ -432,6 +433,12 @@ int main(int argc, char** argv) {
doris::ExecEnv::init(exec_env, paths);
doris::TabletSchemaCache::create_global_schema_cache();
+ // init s3 write buffer pool
+ doris::io::S3FileBufferPool* s3_buffer_pool = doris::io::S3FileBufferPool::GetInstance();
+ s3_buffer_pool->init(doris::config::s3_write_buffer_whole_size,
+ doris::config::s3_write_buffer_size,
+ exec_env->buffered_reader_prefetch_thread_pool());
Review Comment:
I didn't change the origin logic.
Maybe we can use separate pool in next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20926: [feature](fs)add fs_s3 benchmark tool
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1594822518
Please give an example to show the results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature](fs)add fs_s3 benchmark tool
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1596156039
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #20926: [feature](fs)add fs_s3 benchmark tool
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #20926:
URL: https://github.com/apache/doris/pull/20926#discussion_r1232351246
##########
be/src/io/fs/benchmark/s3_benchmark.hpp:
##########
@@ -52,4 +55,164 @@ class S3ReadBenchmark : public BaseBenchmark {
size_t _bytes_read = 0;
};
+class S3SizeBenchmark : public BaseBenchmark {
Review Comment:
This is meaningless. Because the method `size()` is just return the `_size` field.
No action to do with S3.
##########
be/src/io/fs/benchmark/s3_benchmark.hpp:
##########
@@ -52,4 +55,164 @@ class S3ReadBenchmark : public BaseBenchmark {
size_t _bytes_read = 0;
};
+class S3SizeBenchmark : public BaseBenchmark {
+public:
+ S3SizeBenchmark(int iterations, const std::map<std::string, std::string>& conf_map)
+ : BaseBenchmark("S3SizeBenchmark", iterations, conf_map) {}
+ virtual ~S3SizeBenchmark() = default;
+
+ Status init() override {
+ bm_log("begin to init {}", _name);
+ std::string file_path = _conf_map["file"];
+ io::FileReaderOptions reader_opts = FileFactory::get_reader_options(nullptr);
+ RETURN_IF_ERROR(
+ FileFactory::create_s3_reader(_conf_map, file_path, &_fs, &_reader, reader_opts));
+ bm_log("finish to init {}", _name);
+ return Status::OK();
+ }
+
+ Status run() override {
+ size_t i = _reader->size();
+ bm_log("size result is: {}", i);
+ return Status::OK();
+ }
+
+private:
+ std::shared_ptr<io::FileSystem> _fs;
+ io::FileReaderSPtr _reader;
+};
+
+class S3ListBenchmark : public BaseBenchmark {
+public:
+ S3ListBenchmark(int iterations, const std::map<std::string, std::string>& conf_map)
+ : BaseBenchmark("S3ListBenchmark", iterations, conf_map) {}
+ virtual ~S3ListBenchmark() = default;
+
+ Status init() override {
+ bm_log("begin to init {}", _name);
+ S3URI s3_uri(_conf_map["file"]);
+ RETURN_IF_ERROR(s3_uri.parse());
+ RETURN_IF_ERROR(
+ S3ClientFactory::convert_properties_to_s3_conf(_conf_map, s3_uri, &_s3_conf));
+ RETURN_IF_ERROR(io::S3FileSystem::create(std::move(_s3_conf), "", &_fs));
+ bm_log("finish to init {}", _name);
+ return Status::OK();
+ }
+
+ Status run() override {
+ std::vector<FileInfo> files;
+ bool exists = true;
+ _fs->list(_conf_map["file"], true, &files, &exists);
+ bm_log("list result is: {}", files.size());
+ return Status::OK();
+ }
+
+private:
+ doris::S3Conf _s3_conf;
+ std::shared_ptr<io::S3FileSystem> _fs;
+};
+
+class S3OpenBenchmark : public BaseBenchmark {
+public:
+ S3OpenBenchmark(int iterations, const std::map<std::string, std::string>& conf_map)
+ : BaseBenchmark("S3OpenBenchmark", iterations, conf_map) {}
+ virtual ~S3OpenBenchmark() = default;
+
+ Status init() override {
+ bm_log("begin to init {}", _name);
+ S3URI s3_uri(_conf_map["file"]);
+ RETURN_IF_ERROR(s3_uri.parse());
+ RETURN_IF_ERROR(
+ S3ClientFactory::convert_properties_to_s3_conf(_conf_map, s3_uri, &_s3_conf));
+ RETURN_IF_ERROR(io::S3FileSystem::create(std::move(_s3_conf), "", &_fs));
+
+ std::string file_path = _conf_map["file"];
+ io::FileReaderOptions reader_opts = FileFactory::get_reader_options(nullptr);
+ RETURN_IF_ERROR(FileFactory::create_s3_reader(
+ _conf_map, file_path, reinterpret_cast<std::shared_ptr<io::FileSystem>*>(&_fs),
+ &_reader, reader_opts));
+ bm_log("finish to init {}", _name);
+ return Status::OK();
+ }
+
+ Status run() override { return _fs->open_file(_conf_map["file"], &_reader); }
Review Comment:
Missing `const FileReaderOptions& reader_options` in `open_file`'s parameter list?
##########
be/src/io/fs/benchmark/s3_benchmark.hpp:
##########
@@ -52,4 +55,164 @@ class S3ReadBenchmark : public BaseBenchmark {
size_t _bytes_read = 0;
};
+class S3SizeBenchmark : public BaseBenchmark {
Review Comment:
You need to call `s3_file_system`'s `file_size_impl()`
##########
be/src/io/fs/benchmark/s3_benchmark.hpp:
##########
@@ -52,4 +55,164 @@ class S3ReadBenchmark : public BaseBenchmark {
size_t _bytes_read = 0;
};
+class S3SizeBenchmark : public BaseBenchmark {
+public:
+ S3SizeBenchmark(int iterations, const std::map<std::string, std::string>& conf_map)
+ : BaseBenchmark("S3SizeBenchmark", iterations, conf_map) {}
+ virtual ~S3SizeBenchmark() = default;
+
+ Status init() override {
+ bm_log("begin to init {}", _name);
+ std::string file_path = _conf_map["file"];
+ io::FileReaderOptions reader_opts = FileFactory::get_reader_options(nullptr);
+ RETURN_IF_ERROR(
+ FileFactory::create_s3_reader(_conf_map, file_path, &_fs, &_reader, reader_opts));
+ bm_log("finish to init {}", _name);
+ return Status::OK();
+ }
+
+ Status run() override {
+ size_t i = _reader->size();
+ bm_log("size result is: {}", i);
+ return Status::OK();
+ }
+
+private:
+ std::shared_ptr<io::FileSystem> _fs;
+ io::FileReaderSPtr _reader;
+};
+
+class S3ListBenchmark : public BaseBenchmark {
+public:
+ S3ListBenchmark(int iterations, const std::map<std::string, std::string>& conf_map)
+ : BaseBenchmark("S3ListBenchmark", iterations, conf_map) {}
+ virtual ~S3ListBenchmark() = default;
+
+ Status init() override {
+ bm_log("begin to init {}", _name);
+ S3URI s3_uri(_conf_map["file"]);
+ RETURN_IF_ERROR(s3_uri.parse());
+ RETURN_IF_ERROR(
+ S3ClientFactory::convert_properties_to_s3_conf(_conf_map, s3_uri, &_s3_conf));
+ RETURN_IF_ERROR(io::S3FileSystem::create(std::move(_s3_conf), "", &_fs));
+ bm_log("finish to init {}", _name);
+ return Status::OK();
+ }
+
+ Status run() override {
+ std::vector<FileInfo> files;
+ bool exists = true;
+ _fs->list(_conf_map["file"], true, &files, &exists);
+ bm_log("list result is: {}", files.size());
Review Comment:
log here is too much
##########
be/src/runtime/exec_env.h:
##########
@@ -182,6 +182,9 @@ class ExecEnv {
this->_stream_load_executor = stream_load_executor;
}
+ // Threadpool used to prefetch remote file for buffered reader
+ std::unique_ptr<ThreadPool> _buffered_reader_prefetch_thread_pool;
Review Comment:
Should not just move it to public. Use get and set method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #20926:
URL: https://github.com/apache/doris/pull/20926#discussion_r1243188619
##########
be/src/runtime/exec_env.h:
##########
@@ -185,6 +185,9 @@ class ExecEnv {
void set_stream_load_executor(std::shared_ptr<StreamLoadExecutor> stream_load_executor) {
this->_stream_load_executor = stream_load_executor;
}
+ void set_buffered_reader_prefetch_thread_pool(ThreadPool* thread_pool) {
Review Comment:
uesless, I removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature](fs)add fs_s3 benchmark tool
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1594630918
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20926: [feature](fs)add fs_s3 benchmark tool
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1605295263
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature](fs)add fs_s3 benchmark tool
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1608781624
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1608807944
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20926: [feature](fix)(fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1608807354
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1608879324
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20926:
URL: https://github.com/apache/doris/pull/20926#issuecomment-1608900484
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org