Re: [PR] [SPARK-47152][SQL][BUILD] Provide `CodeHaus Jackson` dependencies via a new optional directory [spark]

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #45237:
URL: https://github.com/apache/spark/pull/45237#discussion_r1501306714


##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -64,8 +65,16 @@ package object config {
       .stringConf
       .createOptional
 
+  private[spark] val DRIVER_DEFAULT_EXTRA_CLASS_PATH =
+    ConfigBuilder(SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH)
+      .internal()
+      .version("4.0.0")
+      .stringConf
+      .createWithDefault(SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH_VALUE)
+
   private[spark] val DRIVER_CLASS_PATH =
     ConfigBuilder(SparkLauncher.DRIVER_EXTRA_CLASSPATH)
+      .withPrepended(DRIVER_DEFAULT_EXTRA_CLASS_PATH.key, File.pathSeparator)

Review Comment:
   Hmm, so looks like users can simply set `SparkLauncher.DRIVER_EXTRA_CLASSPATH` to achieve same effect, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org