You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Jakub Białek (JIRA)" <ji...@apache.org> on 2010/09/22 08:54:32 UTC

[jira] Created: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Incomplite album and mediaitem support in JS
--------------------------------------------

                 Key: SHINDIG-1429
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
             Project: Shindig
          Issue Type: Bug
          Components: Javascript 
    Affects Versions: 2.0.0
            Reporter: Jakub Białek


Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
* incorrect fields' names in opensocial.Album
* missing fields in opensocial.MediaItem
* missing opensocial.DataRequest.MediaItemRequestFields
* missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saputra updated SHINDIG-1429:
-----------------------------------

    Attachment:     (was: shindig-1429.patch)

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>         Attachments: shindig_album_mediaitem.patch, shindig_album_mediaitem_trunk.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saputra updated SHINDIG-1429:
-----------------------------------

    Attachment: shindig-1429.patch

Proposed fix for shindig-1429

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>         Attachments: shindig-1429.patch, shindig_album_mediaitem.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Jakub Białek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913437#action_12913437 ] 

Jakub Białek commented on SHINDIG-1429:
---------------------------------------

Patch available for code review at http://codereview.appspot.com/2265043/

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>         Attachments: shindig_album_mediaitem.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saputra updated SHINDIG-1429:
-----------------------------------

    Comment: was deleted

(was: I added new codereview to reflect proposed change form Jakub: http://codereview.appspot.com/2246045/.

The original patch was created from 2.0 branch and I was having problem applying to trunk. It also missing jsonalbum.js and jsonmediaitem.js files.

The patch file is attached as shindig-1429.patch file.

)

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>         Attachments: shindig_album_mediaitem.patch, shindig_album_mediaitem_trunk.patch, shindig_album_mediaitem_trunk_v2.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Jakub Białek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakub Białek updated SHINDIG-1429:
----------------------------------

    Attachment: shindig_album_mediaitem.patch

This patch contains:
* fixed opensocial.Album fields names
* added fields to opensocial.MediaItem
* added functions: newCreateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newFetchMediaItemsRequest

This patch doesn't contain implementation of newUpdateAlbumRequest and newUpdateMediaItemRequest

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>         Attachments: shindig_album_mediaitem.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saputra updated SHINDIG-1429:
-----------------------------------

    Fix Version/s: 2.0.1

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>             Fix For: 2.0.1, 3.0.0
>
>         Attachments: shindig_album_mediaitem.patch, shindig_album_mediaitem_trunk.patch, shindig_album_mediaitem_trunk_v2.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Jakub Białek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakub Białek updated SHINDIG-1429:
----------------------------------

    Attachment: shindig_album_mediaitem_trunk.patch

Previously attached patch shindig_album_mediaitem was created using Shindig 2.0.0: http://svn.apache.org/repos/asf/shindig/tags/shindig-project-2.0.0/ as a base code, also some files were missing.
New patch shindig_album_mediaitem_trunk.patch was created using Shindig trunk and contains JsonAlbum.js and JsonMediaItem.js files.

Patch available for code review at http://codereview.appspot.com/2265043/ as a patch set 2.

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>         Attachments: shindig-1429.patch, shindig_album_mediaitem.patch, shindig_album_mediaitem_trunk.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913903#action_12913903 ] 

Henry Saputra commented on SHINDIG-1429:
----------------------------------------

I added new codereview to reflect proposed change form Jakub: http://codereview.appspot.com/2246045/.

The original patch was created from 2.0 branch and I was having problem applying to trunk. It also missing jsonalbum.js and jsonmediaitem.js files.

The patch file is attached as shindig-1429.patch file.



> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>         Attachments: shindig-1429.patch, shindig_album_mediaitem.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913459#action_12913459 ] 

Henry Saputra commented on SHINDIG-1429:
----------------------------------------

You are using wrong base URL for the code review.

Instead of http://svn.apache.org/repos/asf/incubator/shindig/trunk/trunk/ it should be http://svn.apache.org/repos/asf/shindig/trunk

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>         Attachments: shindig_album_mediaitem.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913942#action_12913942 ] 

Henry Saputra commented on SHINDIG-1429:
----------------------------------------

Deleting my attachment patch since Jakub has uploaded updated one from trunk.

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>         Attachments: shindig_album_mediaitem.patch, shindig_album_mediaitem_trunk.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Jakub Białek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakub Białek updated SHINDIG-1429:
----------------------------------

    Attachment: shindig_album_mediaitem_trunk_v2.patch

I've add opensocial.newAlbum method and modified taming.js

Patch available for code review at http://codereview.appspot.com/2265043/ as a patch set 3.

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>         Attachments: shindig_album_mediaitem.patch, shindig_album_mediaitem_trunk.patch, shindig_album_mediaitem_trunk_v2.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Jakub Białek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913462#action_12913462 ] 

Jakub Białek commented on SHINDIG-1429:
---------------------------------------

I've changed base URL to http://svn.apache.org/repos/asf/shindig/trunk

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>         Attachments: shindig_album_mediaitem.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-1429) Incomplite album and mediaitem support in JS

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saputra resolved SHINDIG-1429.
------------------------------------

    Fix Version/s: 3.0.0
       Resolution: Fixed

Patch applied with svn commit: r1000605 

> Incomplite album and mediaitem support in JS
> --------------------------------------------
>
>                 Key: SHINDIG-1429
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1429
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Jakub Białek
>             Fix For: 3.0.0
>
>         Attachments: shindig_album_mediaitem.patch, shindig_album_mediaitem_trunk.patch, shindig_album_mediaitem_trunk_v2.patch
>
>
> Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.
> * incorrect fields' names in opensocial.Album
> * missing fields in opensocial.MediaItem
> * missing opensocial.DataRequest.MediaItemRequestFields
> * missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.