You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 19:54:51 UTC

[GitHub] [airflow] o-nikolas commented on issue #26571: Migrate Amazon Provider Package's `SecretsManagerBackend`'s `full_url_mode=False` implementation.

o-nikolas commented on issue #26571:
URL: https://github.com/apache/airflow/issues/26571#issuecomment-1255483307

   Hey @dwreeves, thanks for this fantastically detailed write-up! Although my head is still spinning a bit, it would be worse if this post wasn't as detailed as it is, so thanks again :smiley: 
   
   Personally, I don't think we should be so afraid of breaking changes, especially ones that affect such small percentages of users. To me it can be **more** of a risk to maintain complicated code for longer periods of time and also having ambiguous behaviours for longer allows folks to happily use the old features even when they should be moving off of them. And at the end of the day, sem ver versioning does it's job, folks can stick to older versions if they _really_ require these strange old behaviours. If some super valuable bug fix arrives in a future version, we can always think about cherry-picking it backwards using the shared governance model @potiuk outlined earlier this year.
   
   So, I'm happy to combine steps 1 and 2, and after waiting appropriately long enough, to go ahead with step 3. But I'd love to hear what others think as well.
   
   Cheers,
   Niko


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org