You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/14 12:21:03 UTC

[GitHub] [flink] zentol opened a new pull request, #20836: [FLINK-29301] Publish flink-ci-tools

zentol opened a new pull request, #20836:
URL: https://github.com/apache/flink/pull/20836

   Publish the `java-ci-tools` (after renaming them to flink-ci-tools) so that external connectors can also use it for license checks etc.
   
   Additionally fixes a few issues about resources and modules skipping deployments to make it usable outside the Flink repo / CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] alpinegizmo commented on a diff in pull request #20836: [FLINK-29301] Publish flink-ci-tools

Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on code in PR #20836:
URL: https://github.com/apache/flink/pull/20836#discussion_r971266850


##########
tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/NoticeFileChecker.java:
##########
@@ -62,6 +62,10 @@ public class NoticeFileChecker {
     private static final Pattern SHADE_INCLUDE_MODULE_PATTERN =
             Pattern.compile(".*Including ([^:]+):([^:]+):jar:([^ ]+) in the shaded jar");
 
+    private static final Pattern DEPLOY_MODULE_PATTERN =

Review Comment:
   This would be easier to understand if we added a comment showing an example of a string this pattern is applied to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] alpinegizmo commented on pull request #20836: [FLINK-29301] Publish flink-ci-tools

Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on PR #20836:
URL: https://github.com/apache/flink/pull/20836#issuecomment-1247158004

   Overall the code in licensecheck/NoticeFileChecker.java is complex enough that I'm wondering how we know for sure that it works. Are there tests somewhere?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zentol commented on pull request #20836: [FLINK-29301] Publish flink-ci-tools

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20836:
URL: https://github.com/apache/flink/pull/20836#issuecomment-1247258952

   We don't really have tests for NoticeChecker, however one can infer the correctness from the logging output on CI: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=41020&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb
   
   If the parsing of modules from the build output is broken then this line shows it:
   `...Extracted 157 modules that were deployed of which 48 bundle dependencies with a total of 779 dependencies`
   
   For finding the NOTICE files we got:
   `... Found 44 NOTICE files to check`
   
   If the parsing of dependencies from the build output is broken, then we get warnings for all modules.
   
   If the parsing of dependencies from NOTICE is broken, then we get errors for all modules.
   
   Finally, if the comparison of the dependencies between NOTICE/build-output is broken then either everything fails or no warnings are logged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #20836: [FLINK-29301] Publish flink-ci-tools

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20836:
URL: https://github.com/apache/flink/pull/20836#issuecomment-1246689383

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "323f1def2dc20338c6adc1b52d7ec160c0b71a9a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "323f1def2dc20338c6adc1b52d7ec160c0b71a9a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 323f1def2dc20338c6adc1b52d7ec160c0b71a9a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zentol merged pull request #20836: [FLINK-29301] Publish flink-ci-tools

Posted by GitBox <gi...@apache.org>.
zentol merged PR #20836:
URL: https://github.com/apache/flink/pull/20836


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org