You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2019/02/19 17:06:30 UTC
Review Request 70009: Exposed `memfd_create` syscall via `createMemFd`
function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70009/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Joseph Wu.
Bugs: MESOS-9564
https://issues.apache.org/jira/browse/MESOS-9564
Repository: mesos
Description
-------
This patch exposes a wrapper function for `memfd_create` system call.
This function can be used to create an anonymous in-memory files on
Linux.
Diffs
-----
src/linux/memfd.hpp 4cf9906cd9a6624b2e6e555c0b50fc3d4868b2d7
src/linux/memfd.cpp 348d0ced0ddd5be6dabd7cd52f5460cda36e3e49
Diff: https://reviews.apache.org/r/70009/diff/1/
Testing
-------
Thanks,
Andrei Budnik
Re: Review Request 70009: Exposed `memfd_create` syscall via
`createMemFd` function.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70009/#review213010
-----------------------------------------------------------
Fix it, then Ship it!
src/linux/memfd.hpp
Lines 39 (patched)
<https://reviews.apache.org/r/70009/#comment298863>
could we stick with `create()` name given we already have the namespace?
- Gilbert Song
On Feb. 19, 2019, 9:06 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70009/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2019, 9:06 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-9564
> https://issues.apache.org/jira/browse/MESOS-9564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch exposes a wrapper function for `memfd_create` system call.
> This function can be used to create an anonymous in-memory files on
> Linux.
>
>
> Diffs
> -----
>
> src/linux/memfd.hpp 4cf9906cd9a6624b2e6e555c0b50fc3d4868b2d7
> src/linux/memfd.cpp 348d0ced0ddd5be6dabd7cd52f5460cda36e3e49
>
>
> Diff: https://reviews.apache.org/r/70009/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70009: Exposed `memfd_create` syscall via
`createMemFd` function.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70009/#review212922
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Feb. 19, 2019, 9:06 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70009/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2019, 9:06 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-9564
> https://issues.apache.org/jira/browse/MESOS-9564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch exposes a wrapper function for `memfd_create` system call.
> This function can be used to create an anonymous in-memory files on
> Linux.
>
>
> Diffs
> -----
>
> src/linux/memfd.hpp 4cf9906cd9a6624b2e6e555c0b50fc3d4868b2d7
> src/linux/memfd.cpp 348d0ced0ddd5be6dabd7cd52f5460cda36e3e49
>
>
> Diff: https://reviews.apache.org/r/70009/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>