[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7405: Introduce Native Text Indices (Core Functionality)

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#discussion_r710556941



##########
File path: pinot-segment-local/pom.xml
##########
@@ -156,5 +156,30 @@
       <type>test-jar</type>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>com.carrotsearch</groupId>
+      <artifactId>hppc</artifactId>
+      <version>0.7.2</version>
+    </dependency>
+    <dependency>
+      <groupId>org.openjdk.jmh</groupId>

Review comment:
       We keep all the micro-benchmark in the `pinot-perf` package. Let's not introducing jmh in the production code package but move the perf class into the `pinot-perf`

##########
File path: pinot-segment-local/pom.xml
##########
@@ -156,5 +156,30 @@
       <type>test-jar</type>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>com.carrotsearch</groupId>
+      <artifactId>hppc</artifactId>

Review comment:
       We use `it.unimi.dsi.fastutil` for the primitive type data structures (e.g. `it.unimi.dsi.fastutil.ints.Int2IntOpenHashMap`). Let's try to reduce the external dependency unless there is some clear benefits of introducing this new library




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org