You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by bh...@apache.org on 2023/11/20 22:01:14 UTC
(samza) branch SAMZA-2763 created (now 740fd99d9)
This is an automated email from the ASF dual-hosted git repository.
bharathkk pushed a change to branch SAMZA-2763
in repository https://gitbox.apache.org/repos/asf/samza.git
at 740fd99d9 Address comments
This branch includes the following new commits:
new 740fd99d9 Address comments
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(samza) 01/01: Address comments
Posted by bh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
bharathkk pushed a commit to branch SAMZA-2763
in repository https://gitbox.apache.org/repos/asf/samza.git
commit 740fd99d95fb2ca37f0fcb338b5d224f05ced7fe
Author: Bharath Kumarasubramanian <bh...@apache.org>
AuthorDate: Mon Nov 20 14:01:01 2023 -0800
Address comments
---
.../src/main/java/org/apache/samza/config/ShellCommandConfig.java | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/samza-core/src/main/java/org/apache/samza/config/ShellCommandConfig.java b/samza-core/src/main/java/org/apache/samza/config/ShellCommandConfig.java
index 3cbbf0321..90780c81d 100644
--- a/samza-core/src/main/java/org/apache/samza/config/ShellCommandConfig.java
+++ b/samza-core/src/main/java/org/apache/samza/config/ShellCommandConfig.java
@@ -106,6 +106,9 @@ public class ShellCommandConfig extends MapConfig {
return Optional.ofNullable(getFinalJvmOptions(taskOpts, autosizingContainerMaxHeap));
}
+ /**
+ * Returns the worker opts for the application if available.
+ */
public Optional<String> getWorkerOpts() {
String autosizingWorkerHeapMb = get(JobConfig.JOB_AUTOSIZING_WORKER_MAX_HEAP_MB);
String workerOpts = get(ShellCommandConfig.WORKER_JVM_OPTS);
@@ -120,6 +123,9 @@ public class ShellCommandConfig extends MapConfig {
return Optional.ofNullable(get(ShellCommandConfig.ADDITIONAL_CLASSPATH_DIR));
}
+ /**
+ * Returns the final JVM options by applying the heap override if available to the jvm opts
+ */
@VisibleForTesting
String getFinalJvmOptions(String jvmOpts, String maxHeapOverride) {
String finalJvmOpts = jvmOpts;