You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jose Quinteiro (Created) (JIRA)" <ji...@apache.org> on 2012/03/14 18:56:40 UTC
[jira] [Created] (KAFKA-303) Dead code in the Log4j appender
Dead code in the Log4j appender
-------------------------------
Key: KAFKA-303
URL: https://issues.apache.org/jira/browse/KAFKA-303
Project: Kafka
Issue Type: Improvement
Components: core
Reporter: Jose Quinteiro
Priority: Trivial
The log4j appender has the following class definition in it:
class DefaultStringEncoder extends Encoder[LoggingEvent] {
override def toMessage(event: LoggingEvent):Message = new Message(event.getMessage.asInstanceOf[String].getBytes)
}
This left over and no longer used. The current version uses kafka.serializer.StringEncoder as the default encoder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-303) Dead code in the Log4j appender
Posted by "Jose Quinteiro (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jose Quinteiro updated KAFKA-303:
---------------------------------
Status: Open (was: Patch Available)
> Dead code in the Log4j appender
> -------------------------------
>
> Key: KAFKA-303
> URL: https://issues.apache.org/jira/browse/KAFKA-303
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Jose Quinteiro
> Priority: Trivial
> Labels: log4j
>
> The log4j appender has the following class definition in it:
> class DefaultStringEncoder extends Encoder[LoggingEvent] {
> override def toMessage(event: LoggingEvent):Message = new Message(event.getMessage.asInstanceOf[String].getBytes)
> }
> This left over and no longer used. The current version uses kafka.serializer.StringEncoder as the default encoder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-303) Dead code in the Log4j appender
Posted by "Jose Quinteiro (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jose Quinteiro updated KAFKA-303:
---------------------------------
Status: Patch Available (was: Open)
> Dead code in the Log4j appender
> -------------------------------
>
> Key: KAFKA-303
> URL: https://issues.apache.org/jira/browse/KAFKA-303
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Jose Quinteiro
> Priority: Trivial
> Labels: log4j
>
> The log4j appender has the following class definition in it:
> class DefaultStringEncoder extends Encoder[LoggingEvent] {
> override def toMessage(event: LoggingEvent):Message = new Message(event.getMessage.asInstanceOf[String].getBytes)
> }
> This left over and no longer used. The current version uses kafka.serializer.StringEncoder as the default encoder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-303) Dead code in the Log4j appender
Posted by "Jun Rao (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated KAFKA-303:
--------------------------
Resolution: Fixed
Fix Version/s: 0.7.1
Status: Resolved (was: Patch Available)
Jose,
Thanks for the patch. Just committed to trunk.
> Dead code in the Log4j appender
> -------------------------------
>
> Key: KAFKA-303
> URL: https://issues.apache.org/jira/browse/KAFKA-303
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Jose Quinteiro
> Priority: Trivial
> Labels: log4j
> Fix For: 0.7.1
>
>
> The log4j appender has the following class definition in it:
> class DefaultStringEncoder extends Encoder[LoggingEvent] {
> override def toMessage(event: LoggingEvent):Message = new Message(event.getMessage.asInstanceOf[String].getBytes)
> }
> This left over and no longer used. The current version uses kafka.serializer.StringEncoder as the default encoder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-303) Dead code in the Log4j appender
Posted by "Jose Quinteiro (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jose Quinteiro updated KAFKA-303:
---------------------------------
Status: Patch Available (was: Open)
Index: core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala
===================================================================
--- core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala (revision 1300634)
+++ core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala (working copy)
@@ -93,8 +93,4 @@
}
override def requiresLayout: Boolean = false
-}
-
-class DefaultStringEncoder extends Encoder[LoggingEvent] {
- override def toMessage(event: LoggingEvent):Message = new Message(event.getMessage.asInstanceOf[String].getBytes)
-}
+}
> Dead code in the Log4j appender
> -------------------------------
>
> Key: KAFKA-303
> URL: https://issues.apache.org/jira/browse/KAFKA-303
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Jose Quinteiro
> Priority: Trivial
> Labels: log4j
>
> The log4j appender has the following class definition in it:
> class DefaultStringEncoder extends Encoder[LoggingEvent] {
> override def toMessage(event: LoggingEvent):Message = new Message(event.getMessage.asInstanceOf[String].getBytes)
> }
> This left over and no longer used. The current version uses kafka.serializer.StringEncoder as the default encoder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira