You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/02 16:25:15 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #7223: ARROW-8711: [Python] Expose timestamp_parsers in csv.ConvertOptions

pitrou commented on a change in pull request #7223:
URL: https://github.com/apache/arrow/pull/7223#discussion_r434010492



##########
File path: cpp/src/arrow/util/value_parsing.h
##########
@@ -45,6 +45,10 @@ class ARROW_EXPORT TimestampParser {
   virtual bool operator()(const char* s, size_t length, TimeUnit::type out_unit,
                           int64_t* out) const = 0;
 
+  virtual const char* kind() const = 0;
+
+  virtual const char* detail() const;

Review comment:
       How would you do it otherwise?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org