You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/11 20:45:32 UTC
[GitHub] [tvm] d-smirnov opened a new pull request #7251: [BYOC][ACL] removed ACL 20.05 limitations
d-smirnov opened a new pull request #7251:
URL: https://github.com/apache/tvm/pull/7251
This PR removes checks for padding in according with changes in ACL 20.11 which currently does not require padded data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] d-smirnov commented on a change in pull request #7251: [BYOC][ACL] removed ACL 20.05 limitations
Posted by GitBox <gi...@apache.org>.
d-smirnov commented on a change in pull request #7251:
URL: https://github.com/apache/tvm/pull/7251#discussion_r559784450
##########
File path: tests/python/contrib/test_arm_compute_lib/test_dense.py
##########
@@ -101,7 +101,7 @@ def _get_qnn_model(
out = relay.qnn.op.requantize(
out,
relay.const(input_sc * kernel_sc, "float32"), # input scale
- relay.const(input_zp * kernel_zp, "int32"), # input zero point
+ relay.const(0, "int32"), # input zero point
Review comment:
Should be zero, as dense already counted all the input zero points in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] d-smirnov commented on pull request #7251: [BYOC][ACL] removed ACL 20.05 limitations
Posted by GitBox <gi...@apache.org>.
d-smirnov commented on pull request #7251:
URL: https://github.com/apache/tvm/pull/7251#issuecomment-763535804
Ping. How we can make a progress here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbaret commented on pull request #7251: [BYOC][ACL] removed ACL 20.05 limitations
Posted by GitBox <gi...@apache.org>.
mbaret commented on pull request #7251:
URL: https://github.com/apache/tvm/pull/7251#issuecomment-763550274
Thanks @d-smirnov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbaret commented on a change in pull request #7251: [BYOC][ACL] removed ACL 20.05 limitations
Posted by GitBox <gi...@apache.org>.
mbaret commented on a change in pull request #7251:
URL: https://github.com/apache/tvm/pull/7251#discussion_r559767312
##########
File path: tests/python/contrib/test_arm_compute_lib/test_dense.py
##########
@@ -101,7 +101,7 @@ def _get_qnn_model(
out = relay.qnn.op.requantize(
out,
relay.const(input_sc * kernel_sc, "float32"), # input scale
- relay.const(input_zp * kernel_zp, "int32"), # input zero point
+ relay.const(0, "int32"), # input zero point
Review comment:
What's the relevance of this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] d-smirnov commented on pull request #7251: [BYOC][ACL] removed ACL 20.05 limitations
Posted by GitBox <gi...@apache.org>.
d-smirnov commented on pull request #7251:
URL: https://github.com/apache/tvm/pull/7251#issuecomment-758212449
@mbaret
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] d-smirnov commented on pull request #7251: [BYOC][ACL] removed ACL 20.05 limitations
Posted by GitBox <gi...@apache.org>.
d-smirnov commented on pull request #7251:
URL: https://github.com/apache/tvm/pull/7251#issuecomment-762460528
Correct. Tests were restored to initial state (before padding limitations). Now each test always resulted to ACL-partitioned IR so there is no need to have this variations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbaret merged pull request #7251: [BYOC][ACL] removed ACL 20.05 limitations
Posted by GitBox <gi...@apache.org>.
mbaret merged pull request #7251:
URL: https://github.com/apache/tvm/pull/7251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org