You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/12/19 08:54:29 UTC
[kudu-CR] [metrics] Modify metrics 'raft term' and 'time since last leader heartbeat' to MAX merge type
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14933
Change subject: [metrics] Modify metrics 'raft_term' and 'time_since_last_leader_heartbeat' to MAX merge type
......................................................................
[metrics] Modify metrics 'raft_term' and 'time_since_last_leader_heartbeat' to MAX merge type
Change-Id: I915e4a4121175ff58bd814090f67fe99edef7141
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/14933/1
--
To view, visit http://gerrit.cloudera.org:8080/14933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I915e4a4121175ff58bd814090f67fe99edef7141
Gerrit-Change-Number: 14933
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
[kudu-CR] [metrics] Modify metrics 'raft term' and 'time since last leader heartbeat' to MAX merge type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14933 )
Change subject: [metrics] Modify metrics 'raft_term' and 'time_since_last_leader_heartbeat' to MAX merge type
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I915e4a4121175ff58bd814090f67fe99edef7141
Gerrit-Change-Number: 14933
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Dec 2019 23:47:21 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Modify metrics 'raft term' and 'time since last leader heartbeat' to MAX merge type
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14933 )
Change subject: [metrics] Modify metrics 'raft_term' and 'time_since_last_leader_heartbeat' to MAX merge type
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I915e4a4121175ff58bd814090f67fe99edef7141
Gerrit-Change-Number: 14933
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Dec 2019 01:37:12 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] Modify metrics 'raft term' and 'time since last leader heartbeat' to MAX merge type
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14933
to look at the new patch set (#2).
Change subject: [metrics] Modify metrics 'raft_term' and 'time_since_last_leader_heartbeat' to MAX merge type
......................................................................
[metrics] Modify metrics 'raft_term' and 'time_since_last_leader_heartbeat' to MAX merge type
Change-Id: I915e4a4121175ff58bd814090f67fe99edef7141
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/14933/2
--
To view, visit http://gerrit.cloudera.org:8080/14933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I915e4a4121175ff58bd814090f67fe99edef7141
Gerrit-Change-Number: 14933
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [metrics] Modify metrics 'raft term' and 'time since last leader heartbeat' to MAX merge type
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14933 )
Change subject: [metrics] Modify metrics 'raft_term' and 'time_since_last_leader_heartbeat' to MAX merge type
......................................................................
[metrics] Modify metrics 'raft_term' and 'time_since_last_leader_heartbeat' to MAX merge type
Change-Id: I915e4a4121175ff58bd814090f67fe99edef7141
Reviewed-on: http://gerrit.cloudera.org:8080/14933
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I915e4a4121175ff58bd814090f67fe99edef7141
Gerrit-Change-Number: 14933
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)