[GitHub] [hudi] bvaradar commented on a diff in pull request #6799: [HUDI-4920] fix PartialUpdatePayload cannot return deleted record in …

["bvaradar (via GitHub)" <gi...@apache.org>]

bvaradar commented on code in PR #6799:
URL: https://github.com/apache/hudi/pull/6799#discussion_r1113955988


##########
hudi-common/src/main/java/org/apache/hudi/common/model/PartialUpdateAvroPayload.java:
##########
@@ -89,6 +89,13 @@
  */
 public class PartialUpdateAvroPayload extends OverwriteNonDefaultsWithLatestAvroPayload {
 
+  /*
+   flag for deleted record combine logic
+   1 preCombine: if delete record is newer, return merged record with _hoodie_is_deleted = true
+   2 combineAndGetUpdateValue:  return empty since we don't need to store deleted data to storage
+  */
+  private boolean isPreCombining = false;

Review Comment:
   Using member variable for passing state for direct function calls needs to be avoided. Instead pass the isPreCombining as argument to mergeOldRecord calls. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org