[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

[GitBox <gi...@apache.org>]

gyfora commented on code in PR #195:
URL: https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r865820606


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java:
##########
@@ -255,4 +259,45 @@ public static boolean shouldRollBack(
                 .minus(readinessTimeout)
                 .isAfter(Instant.ofEpochMilli(reconciliationStatus.getReconciliationTimestamp()));
     }
+
+    public static boolean shouldRecoverJmDeployment(
+            FlinkDeploymentStatus status, Configuration conf) {
+        boolean enabled =
+                conf.getOptional(
+                                KubernetesOperatorConfigOptions
+                                        .OPERATOR_RECOVER_JM_DEPLOYMENT_ENABLED)
+                        .orElse(
+                                conf.get(FlinkConfigBuilder.FLINK_VERSION)
+                                                .isNewerVersionThan(FlinkVersion.v1_14)
+                                        ? true
+                                        : false);
+
+        return enabled

Review Comment:
   Not in 1.15 as the cluster won't shut down (so the jobmanager deployment is not lost). In flink 1.14 if you enable this it would redeploy the batch job, this is exactly the reason why this is disabled in 1.14 by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org