You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by or...@apache.org on 2014/08/11 12:31:17 UTC
svn commit: r1617238 - in
/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources:
addBinding.html js/qpid/management/addBinding.js
Author: orudyy
Date: Mon Aug 11 10:31:17 2014
New Revision: 1617238
URL: http://svn.apache.org/r1617238
Log:
QPID-5981: Improve look and feel of 'Add binding' dialog in web management console:
make 'Binding Argument' grid height auto-resizable
make 'Binding key' form field required
replace 'Binding Arguments' button captions Add/Delete with +/-
remove empty option for x-qpid-no-local
Modified:
qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/addBinding.html
qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addBinding.js
Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/addBinding.html
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/addBinding.html?rev=1617238&r1=1617237&r2=1617238&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/addBinding.html (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/addBinding.html Mon Aug 11 10:31:17 2014
@@ -38,6 +38,7 @@
data-dojo-props="
name: 'name',
placeHolder: 'Binding Key',
+ required: true,
missingMessage: 'A binding key must be supplied',
title: 'Enter binding key'" />
</div>
@@ -49,8 +50,8 @@
<div class="editNoteBanner">NOTE: Only arguments with name and value will be submitted. To edit, please, click on a grid cell.</div>
<div id="formAddbinding.bindingArguments"></div>
<div>
- <button data-dojo-type="dijit/form/Button" id="formAddbinding.addArgumentButton" type="button">Add</button>
- <button data-dojo-type="dijit/form/Button" id="formAddbinding.deleteArgumentButton" type="button">Delete</button>
+ <button data-dojo-type="dijit/form/Button" id="formAddbinding.addArgumentButton" type="button" data-dojo-props="title:'Add new binding argument'">+</button>
+ <button data-dojo-type="dijit/form/Button" id="formAddbinding.deleteArgumentButton" type="button" data-dojo-props="title:'Remove selected binding argument(s)'">-</button>
</div>
</fieldset>
</div>
Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addBinding.js
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addBinding.js?rev=1617238&r1=1617237&r2=1617238&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addBinding.js (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addBinding.js Mon Aug 11 10:31:17 2014
@@ -14,7 +14,8 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-define(["dojo/_base/xhr",
+define(["dojo/_base/connect",
+ "dojo/_base/xhr",
"dojo/dom",
"dojo/dom-construct",
"dojo/_base/window",
@@ -43,11 +44,10 @@ define(["dojo/_base/xhr",
"dojox/grid/EnhancedGrid",
"dojo/data/ObjectStore",
"dojo/domReady!"],
- function (xhr, dom, construct, win, registry, parser, array, event, json, lang, declare, Memory, FilteringSelect) {
+ function (connect, xhr, dom, construct, win, registry, parser, array, event, json, lang, declare, Memory, FilteringSelect) {
var noLocalValues = new Memory({
data: [
- {name:"", id:null},
{name:"true", id:true},
{name:"false", id:false}
]
@@ -243,7 +243,7 @@ define(["dojo/_base/xhr",
store: objectStore,
singleClickEdit: true,
structure: layout,
- height: "150px",
+ autoHeight: true,
plugins: {indirectSelection: true}
}, argumentsGridNode);
grid.startup();
@@ -253,6 +253,15 @@ define(["dojo/_base/xhr",
var addArgumentButton = registry.byId("formAddbinding.addArgumentButton");
var deleteArgumentButton = registry.byId("formAddbinding.deleteArgumentButton");
+ var toggleGridButtons = function(index)
+ {
+ var data = grid.selection.getSelected();
+ deleteArgumentButton.set("disabled", !data || data.length==0);
+ };
+ connect.connect(grid.selection, 'onSelected', toggleGridButtons);
+ connect.connect(grid.selection, 'onDeselected', toggleGridButtons);
+ deleteArgumentButton.set("disabled", true);
+
addArgumentButton.on("click",
function(event)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org