You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "Brian DePradine (JIRA)" <ji...@apache.org> on 2010/01/20 15:01:54 UTC
[jira] Created: (ARIES-125) Implement a new BundleTracker that
automatically filters out events related to framework bundles in a
composite bundle
Implement a new BundleTracker that automatically filters out events related to framework bundles in a composite bundle
----------------------------------------------------------------------------------------------------------------------
Key: ARIES-125
URL: https://issues.apache.org/jira/browse/ARIES-125
Project: Aries
Issue Type: Improvement
Affects Versions: Incubation
Reporter: Brian DePradine
This new BundleTracker should be aware of what a CompositeBundle is and should automatically handle events related to framework bundles. This should make life a bit easier for clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-125) Implement a new BundleTracker that
automatically filters out events related to framework bundles in a
composite bundle
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803320#action_12803320 ]
Lin Sun commented on ARIES-125:
-------------------------------
Hi,
Sorry I didn't look at this earlier. Here is a few quick comments
1. Did you grant ASF license when you attach the file? I think there is a radio button for it. You'd have to do that before we can commit anything for you.
2. Since this contains new files, could you rework your patch to add ASL 20 license to the file header?
Thanks much for your contribution.
Lin
> Implement a new BundleTracker that automatically filters out events related to framework bundles in a composite bundle
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ARIES-125
> URL: https://issues.apache.org/jira/browse/ARIES-125
> Project: Aries
> Issue Type: Improvement
> Affects Versions: Incubation
> Reporter: Brian DePradine
> Attachments: patch.txt, patch2.txt
>
>
> This new BundleTracker should be aware of what a CompositeBundle is and should automatically handle events related to framework bundles. This should make life a bit easier for clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ARIES-125) Implement a new BundleTracker that
automatically filters out events related to framework bundles in a
composite bundle
Posted by "Brian DePradine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian DePradine updated ARIES-125:
----------------------------------
Attachment: patch2.txt
Hi Valentin,
Thanks for the comments. In order to address the issues that you raised I have now changed the code to implement a BundleTrackerCustomizer instead of extending a BundleTracker. This should get around the problems with methods not working on BundleTrackers.
> Implement a new BundleTracker that automatically filters out events related to framework bundles in a composite bundle
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ARIES-125
> URL: https://issues.apache.org/jira/browse/ARIES-125
> Project: Aries
> Issue Type: Improvement
> Affects Versions: Incubation
> Reporter: Brian DePradine
> Attachments: patch.txt, patch2.txt
>
>
> This new BundleTracker should be aware of what a CompositeBundle is and should automatically handle events related to framework bundles. This should make life a bit easier for clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-125) Implement a new BundleTracker that
automatically filters out events related to framework bundles in a
composite bundle
Posted by "Brian DePradine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803363#action_12803363 ]
Brian DePradine commented on ARIES-125:
---------------------------------------
Hi Lin,
Thanks for spotting that. I had granted the license, but I forgot to add the file header.
> Implement a new BundleTracker that automatically filters out events related to framework bundles in a composite bundle
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ARIES-125
> URL: https://issues.apache.org/jira/browse/ARIES-125
> Project: Aries
> Issue Type: Improvement
> Affects Versions: Incubation
> Reporter: Brian DePradine
> Attachments: patch.txt, patch2.txt
>
>
> This new BundleTracker should be aware of what a CompositeBundle is and should automatically handle events related to framework bundles. This should make life a bit easier for clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-125) Implement a new BundleTracker that
automatically filters out events related to framework bundles in a
composite bundle
Posted by "Valentin Mahrwald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802884#action_12802884 ]
Valentin Mahrwald commented on ARIES-125:
-----------------------------------------
Two things I noticed when I tried to use this in the JPA container:
- The statemask supplied to AriesCompositeBundleTracker is not used (incorrectly, I think) for tracking inside child frameworks
- The class does not correctly handle BundleTracker.getObject, BundleTracker.getBundles and other methods that inspect the currently tracked bundles. I do not think we absolutely need to support these methods (so you could not choose not to inherit from BundleTracker). But if we do, the methods should work as expected.
> Implement a new BundleTracker that automatically filters out events related to framework bundles in a composite bundle
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ARIES-125
> URL: https://issues.apache.org/jira/browse/ARIES-125
> Project: Aries
> Issue Type: Improvement
> Affects Versions: Incubation
> Reporter: Brian DePradine
> Attachments: patch.txt
>
>
> This new BundleTracker should be aware of what a CompositeBundle is and should automatically handle events related to framework bundles. This should make life a bit easier for clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ARIES-125) Implement a new BundleTracker that
automatically filters out events related to framework bundles in a
composite bundle
Posted by "Brian DePradine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian DePradine updated ARIES-125:
----------------------------------
Attachment: patch.txt
Here is a patch containing my implementation of the BundleTracker.
> Implement a new BundleTracker that automatically filters out events related to framework bundles in a composite bundle
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ARIES-125
> URL: https://issues.apache.org/jira/browse/ARIES-125
> Project: Aries
> Issue Type: Improvement
> Affects Versions: Incubation
> Reporter: Brian DePradine
> Attachments: patch.txt
>
>
> This new BundleTracker should be aware of what a CompositeBundle is and should automatically handle events related to framework bundles. This should make life a bit easier for clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (ARIES-125) Implement a new BundleTracker that
automatically filters out events related to framework bundles in a
composite bundle
Posted by "Brian DePradine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian DePradine closed ARIES-125.
---------------------------------
Resolution: Fixed
Fix Version/s: Incubation
> Implement a new BundleTracker that automatically filters out events related to framework bundles in a composite bundle
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ARIES-125
> URL: https://issues.apache.org/jira/browse/ARIES-125
> Project: Aries
> Issue Type: Improvement
> Affects Versions: Incubation
> Reporter: Brian DePradine
> Fix For: Incubation
>
> Attachments: patch.txt, patch2.txt
>
>
> This new BundleTracker should be aware of what a CompositeBundle is and should automatically handle events related to framework bundles. This should make life a bit easier for clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.