[GitHub] d3zd3z commented on a change in pull request #66: image: Add support for RSA-PSS signatures

[gi...@git.apache.org]

d3zd3z commented on a change in pull request #66: image: Add support for RSA-PSS signatures
URL: https://github.com/apache/incubator-mynewt-newt/pull/66#discussion_r120989575
 
 

 ##########
 File path: newt/image/image.go
 ##########
 @@ -46,6 +46,10 @@ import (
 	"mynewt.apache.org/newt/util"
 )
 
+// Set this to enable RSA-PSS for RSA signatures, instead of PKCS#1
+// v1.5.  Eventually, this should be the default.
+var UseRsaPss = false
 
 Review comment:
   I'm not quite sure how this would work. This is the point in the process where we are creating the image header, so none is available yet. Other arguments specify the version, for example.
   
   Other than this option, the signing algorithm comes from the key that the user specified. However with v1.5 vs pss, the same keys are used, and we need some way to specify how this key should be used.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services