You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Andrew Grieve <ag...@google.com> on 2012/09/25 19:18:39 UTC
Timeout of mobile-spec tests
autotest/test-runner.js:
// Timeout is 2 seconds to allow physical devices enough
> // time to query the response. This is important for some
> // Android devices.
> var Tests = function() {};
> Tests.TEST_TIMEOUT = 7500;
The really long timeout is pretty annoying. Any objections to trying to set
this back to 2 seconds?
Re: Timeout of mobile-spec tests
Posted by Filip Maj <fi...@adobe.com>.
Sounds reasonable
On 9/26/12 12:01 PM, "Andrew Grieve" <ag...@chromium.org> wrote:
>wait() and waitFor() calls require you to pass in the timeout. Are there
>any places where the timeout is taken from a global value? Otherwise, I'm
>wondering if we should just make the File tests have a longer timeout, and
>use a small timeout everywhere else. (perhaps FileTransfer as well)
>
>
>On Wed, Sep 26, 2012 at 2:58 PM, Filip Maj <fi...@adobe.com> wrote:
>
>> The file tests. Some of them need this, esp the tests that nest 3-4
>> callbacks together.
>>
>> Run the full suite of tests on old android devices and you'll see what I
>> mean :)
>>
>> On 9/25/12 12:19 PM, "Becky Gibson" <gi...@gmail.com> wrote:
>>
>> >No objections to making it shorter but I think iOS is the reason for
>>the
>> >longer timeouts. If you do change the timeouts please test on an
>>actual
>> >iOS device (or give me a shout and I can try it on an iPhone 4s and
>>ipad 2
>> >both running iOS 6.
>> >
>> >-becky
>> >
>> >On Tue, Sep 25, 2012 at 1:18 PM, Andrew Grieve <ag...@google.com>
>> wrote:
>> >
>> >> autotest/test-runner.js:
>> >>
>> >> // Timeout is 2 seconds to allow physical devices enough
>> >> > // time to query the response. This is important for some
>> >> > // Android devices.
>> >> > var Tests = function() {};
>> >> > Tests.TEST_TIMEOUT = 7500;
>> >>
>> >>
>> >> The really long timeout is pretty annoying. Any objections to trying
>>to
>> >>set
>> >> this back to 2 seconds?
>> >>
>>
>>
Re: Timeout of mobile-spec tests
Posted by Andrew Grieve <ag...@chromium.org>.
wait() and waitFor() calls require you to pass in the timeout. Are there
any places where the timeout is taken from a global value? Otherwise, I'm
wondering if we should just make the File tests have a longer timeout, and
use a small timeout everywhere else. (perhaps FileTransfer as well)
On Wed, Sep 26, 2012 at 2:58 PM, Filip Maj <fi...@adobe.com> wrote:
> The file tests. Some of them need this, esp the tests that nest 3-4
> callbacks together.
>
> Run the full suite of tests on old android devices and you'll see what I
> mean :)
>
> On 9/25/12 12:19 PM, "Becky Gibson" <gi...@gmail.com> wrote:
>
> >No objections to making it shorter but I think iOS is the reason for the
> >longer timeouts. If you do change the timeouts please test on an actual
> >iOS device (or give me a shout and I can try it on an iPhone 4s and ipad 2
> >both running iOS 6.
> >
> >-becky
> >
> >On Tue, Sep 25, 2012 at 1:18 PM, Andrew Grieve <ag...@google.com>
> wrote:
> >
> >> autotest/test-runner.js:
> >>
> >> // Timeout is 2 seconds to allow physical devices enough
> >> > // time to query the response. This is important for some
> >> > // Android devices.
> >> > var Tests = function() {};
> >> > Tests.TEST_TIMEOUT = 7500;
> >>
> >>
> >> The really long timeout is pretty annoying. Any objections to trying to
> >>set
> >> this back to 2 seconds?
> >>
>
>
Re: Timeout of mobile-spec tests
Posted by Filip Maj <fi...@adobe.com>.
The file tests. Some of them need this, esp the tests that nest 3-4
callbacks together.
Run the full suite of tests on old android devices and you'll see what I
mean :)
On 9/25/12 12:19 PM, "Becky Gibson" <gi...@gmail.com> wrote:
>No objections to making it shorter but I think iOS is the reason for the
>longer timeouts. If you do change the timeouts please test on an actual
>iOS device (or give me a shout and I can try it on an iPhone 4s and ipad 2
>both running iOS 6.
>
>-becky
>
>On Tue, Sep 25, 2012 at 1:18 PM, Andrew Grieve <ag...@google.com> wrote:
>
>> autotest/test-runner.js:
>>
>> // Timeout is 2 seconds to allow physical devices enough
>> > // time to query the response. This is important for some
>> > // Android devices.
>> > var Tests = function() {};
>> > Tests.TEST_TIMEOUT = 7500;
>>
>>
>> The really long timeout is pretty annoying. Any objections to trying to
>>set
>> this back to 2 seconds?
>>
Re: Timeout of mobile-spec tests
Posted by Becky Gibson <gi...@gmail.com>.
No objections to making it shorter but I think iOS is the reason for the
longer timeouts. If you do change the timeouts please test on an actual
iOS device (or give me a shout and I can try it on an iPhone 4s and ipad 2
both running iOS 6.
-becky
On Tue, Sep 25, 2012 at 1:18 PM, Andrew Grieve <ag...@google.com> wrote:
> autotest/test-runner.js:
>
> // Timeout is 2 seconds to allow physical devices enough
> > // time to query the response. This is important for some
> > // Android devices.
> > var Tests = function() {};
> > Tests.TEST_TIMEOUT = 7500;
>
>
> The really long timeout is pretty annoying. Any objections to trying to set
> this back to 2 seconds?
>