You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/18 21:54:48 UTC
Review Request 12733: Organize static assets into directories
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12733/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
All static assets were previously in a single folder, except for unused Bootstrap files. This makes template files more apparent since they are the only files in the root of /static.
JavaScript lives in /js
CSS lives in /css
Images live in /img
Icons live in /ico
Objects (e.g. Flash) live in /obj
Original review: https://reviews.apache.org/r/12607/
Diffs
-----
src/Makefile.am d7eb946508a99d272bc8fbd7b53d34e97f68f9c1
src/webui/master/static/angular-1.0.7.js
src/webui/master/static/angular-1.0.7.min.js
src/webui/master/static/app.js 2bfcedf426a61ad86e4536ed188205e4493744e9
src/webui/master/static/bootstrap/css/bootstrap-2.3.2.min.css
src/webui/master/static/bootstrap/css/bootstrap-responsive-2.3.2.min.css
src/webui/master/static/bootstrap/css/docs.css b7e0c8dbfab20b3a0813ac3f69cac36927080d89
src/webui/master/static/bootstrap/ico/favicon.ico
src/webui/master/static/bootstrap/img/bird.png 903e4c78ef5b1f79be7aaa5d3d7feb0abfae3a0b
src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-01.jpg 135c9babb0431578c5d0bda44a284e8bdd5e3824
src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-02.jpg 704e5dfe40596bc46f94c336f2d965294879e371
src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-03.jpg 430fde2cfb6957b0e010889e63355c541f23e4cd
src/webui/master/static/bootstrap/img/browsers.png 73b668d9140ee4371928d95f084ba6fc9b1149be
src/webui/master/static/bootstrap/img/github-16px.png c99ab237a7e77fd149fba63e15e3463b387c0689
src/webui/master/static/bootstrap/img/glyphicons-halflings-white.png
src/webui/master/static/bootstrap/img/glyphicons-halflings.png
src/webui/master/static/bootstrap/img/glyphicons/glyphicons_009_magic.png f1cfb3785f3b1a76a3bdb87d9a34345d27705950
src/webui/master/static/bootstrap/img/glyphicons/glyphicons_042_group.png be5c6f94b560661d614e9f1f30b89bdca347bb40
src/webui/master/static/bootstrap/img/glyphicons/glyphicons_079_podium.png 20b7c99b9d44a8c1e61ad0e26e263ff61dd4c1e8
src/webui/master/static/bootstrap/img/glyphicons/glyphicons_082_roundabout.png e3a6487a01f6a41b1edf9687b2db5e0c960add4a
src/webui/master/static/bootstrap/img/glyphicons/glyphicons_155_show_thumbnails.png 751e3b7184e58edcd7c05beee1d0f227104f10bc
src/webui/master/static/bootstrap/img/glyphicons/glyphicons_163_iphone.png 926df7e5506172b27b22895137b5a1058005ffc4
src/webui/master/static/bootstrap/img/glyphicons/glyphicons_214_resize_small.png 707d9e03e3148636d89aa67a346dd9963be91766
src/webui/master/static/bootstrap/img/glyphicons/glyphicons_266_book_open.png ab04b4a1b3f47fc15d890af14d510fbd6f876395
src/webui/master/static/bootstrap/img/grid-18px-masked.png 1bc82b03ab97f8173d664744abf93e831fe92a07
src/webui/master/static/bootstrap/img/icon-css3.png 58e107235a8e805f20c87f28d58d9d0614c0b79f
src/webui/master/static/bootstrap/img/icon-github.png 1a5fb781e46f35a545f636f6e1039cca61690a2f
src/webui/master/static/bootstrap/img/icon-html5.png 1e8788313acfded4f571e27bfdf1a09973323af9
src/webui/master/static/bootstrap/img/icon-twitter.png a4716545fa6ff394c3b56e52236870268cfb5bc1
src/webui/master/static/bootstrap/img/less-logo-large.png cb56637cbf644ede9beee81798343b7116a3480c
src/webui/master/static/bootstrap/img/less-small.png 93ea597cb707b6c3f0d9c331459388fa8bdd0848
src/webui/master/static/bootstrap/img/responsive-illustrations.png 6ca0f07888b8d7ee1a1691d2daa9030d5dae63c0
src/webui/master/static/bootstrap/js/README.md b58fa1d40746d3300cba2f6fe703699b9ed00691
src/webui/master/static/bootstrap/js/application.js 6463b902fb1697ff916606b575aec8ff7bbb640f
src/webui/master/static/bootstrap/js/google-code-prettify/prettify.css aedd8d1a915767e9fd96ae4b4ec9a088f30c3ca1
src/webui/master/static/bootstrap/js/google-code-prettify/prettify.js eef5ad7e6a07676b3919146d583d1c190bf1e163
src/webui/master/static/bootstrap/js/jquery-1.7.1.js
src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js
src/webui/master/static/bootstrap/js/jquery.js 00c4e23a27b15f6158ea46a016beb0ae95c6596d
src/webui/master/static/controllers.js
src/webui/master/static/cubism.v1.js
src/webui/master/static/cubism.v1.min.js
src/webui/master/static/d3.v2.js
src/webui/master/static/d3.v2.min.js
src/webui/master/static/dashboard.js
src/webui/master/static/graph.css
src/webui/master/static/index.html 342082d15328986246bda214129650dcb541b45a
src/webui/master/static/jquery.pailer.js
src/webui/master/static/loading.gif
src/webui/master/static/mesos.css 34f60673ee7fda7558c63d953318131410901020
src/webui/master/static/pailer.html f91761202966296b940091bfb34e1b52cdd97027
src/webui/master/static/relative-date.js
src/webui/master/static/ui-bootstrap-tpls-0.4.0.js
src/webui/master/static/ui-bootstrap-tpls-0.4.0.min.js
src/webui/master/static/underscore-1.4.3.js
src/webui/master/static/underscore-1.4.3.min.js
src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/12733/diff/
Testing
-------
* Rendered every template to ensure paths were correct
* Ran `make` to ensure Makefile.am paths were correct, and all files were added/removed as needed
Thanks,
Ross Allen
Re: Review Request 12733: Organize static assets into directories
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12733/#review23452
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 18, 2013, 7:54 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12733/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 7:54 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> All static assets were previously in a single folder, except for unused Bootstrap files. This makes template files more apparent since they are the only files in the root of /static.
>
> JavaScript lives in /js
> CSS lives in /css
> Images live in /img
> Icons live in /ico
> Objects (e.g. Flash) live in /obj
>
> Original review: https://reviews.apache.org/r/12607/
>
>
> Diffs
> -----
>
> src/Makefile.am d7eb946508a99d272bc8fbd7b53d34e97f68f9c1
> src/webui/master/static/angular-1.0.7.js
> src/webui/master/static/angular-1.0.7.min.js
> src/webui/master/static/app.js 2bfcedf426a61ad86e4536ed188205e4493744e9
> src/webui/master/static/bootstrap/css/bootstrap-2.3.2.min.css
> src/webui/master/static/bootstrap/css/bootstrap-responsive-2.3.2.min.css
> src/webui/master/static/bootstrap/css/docs.css b7e0c8dbfab20b3a0813ac3f69cac36927080d89
> src/webui/master/static/bootstrap/ico/favicon.ico
> src/webui/master/static/bootstrap/img/bird.png 903e4c78ef5b1f79be7aaa5d3d7feb0abfae3a0b
> src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-01.jpg 135c9babb0431578c5d0bda44a284e8bdd5e3824
> src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-02.jpg 704e5dfe40596bc46f94c336f2d965294879e371
> src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-03.jpg 430fde2cfb6957b0e010889e63355c541f23e4cd
> src/webui/master/static/bootstrap/img/browsers.png 73b668d9140ee4371928d95f084ba6fc9b1149be
> src/webui/master/static/bootstrap/img/github-16px.png c99ab237a7e77fd149fba63e15e3463b387c0689
> src/webui/master/static/bootstrap/img/glyphicons-halflings-white.png
> src/webui/master/static/bootstrap/img/glyphicons-halflings.png
> src/webui/master/static/bootstrap/img/glyphicons/glyphicons_009_magic.png f1cfb3785f3b1a76a3bdb87d9a34345d27705950
> src/webui/master/static/bootstrap/img/glyphicons/glyphicons_042_group.png be5c6f94b560661d614e9f1f30b89bdca347bb40
> src/webui/master/static/bootstrap/img/glyphicons/glyphicons_079_podium.png 20b7c99b9d44a8c1e61ad0e26e263ff61dd4c1e8
> src/webui/master/static/bootstrap/img/glyphicons/glyphicons_082_roundabout.png e3a6487a01f6a41b1edf9687b2db5e0c960add4a
> src/webui/master/static/bootstrap/img/glyphicons/glyphicons_155_show_thumbnails.png 751e3b7184e58edcd7c05beee1d0f227104f10bc
> src/webui/master/static/bootstrap/img/glyphicons/glyphicons_163_iphone.png 926df7e5506172b27b22895137b5a1058005ffc4
> src/webui/master/static/bootstrap/img/glyphicons/glyphicons_214_resize_small.png 707d9e03e3148636d89aa67a346dd9963be91766
> src/webui/master/static/bootstrap/img/glyphicons/glyphicons_266_book_open.png ab04b4a1b3f47fc15d890af14d510fbd6f876395
> src/webui/master/static/bootstrap/img/grid-18px-masked.png 1bc82b03ab97f8173d664744abf93e831fe92a07
> src/webui/master/static/bootstrap/img/icon-css3.png 58e107235a8e805f20c87f28d58d9d0614c0b79f
> src/webui/master/static/bootstrap/img/icon-github.png 1a5fb781e46f35a545f636f6e1039cca61690a2f
> src/webui/master/static/bootstrap/img/icon-html5.png 1e8788313acfded4f571e27bfdf1a09973323af9
> src/webui/master/static/bootstrap/img/icon-twitter.png a4716545fa6ff394c3b56e52236870268cfb5bc1
> src/webui/master/static/bootstrap/img/less-logo-large.png cb56637cbf644ede9beee81798343b7116a3480c
> src/webui/master/static/bootstrap/img/less-small.png 93ea597cb707b6c3f0d9c331459388fa8bdd0848
> src/webui/master/static/bootstrap/img/responsive-illustrations.png 6ca0f07888b8d7ee1a1691d2daa9030d5dae63c0
> src/webui/master/static/bootstrap/js/README.md b58fa1d40746d3300cba2f6fe703699b9ed00691
> src/webui/master/static/bootstrap/js/application.js 6463b902fb1697ff916606b575aec8ff7bbb640f
> src/webui/master/static/bootstrap/js/google-code-prettify/prettify.css aedd8d1a915767e9fd96ae4b4ec9a088f30c3ca1
> src/webui/master/static/bootstrap/js/google-code-prettify/prettify.js eef5ad7e6a07676b3919146d583d1c190bf1e163
> src/webui/master/static/bootstrap/js/jquery-1.7.1.js
> src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js
> src/webui/master/static/bootstrap/js/jquery.js 00c4e23a27b15f6158ea46a016beb0ae95c6596d
> src/webui/master/static/controllers.js
> src/webui/master/static/cubism.v1.js
> src/webui/master/static/cubism.v1.min.js
> src/webui/master/static/d3.v2.js
> src/webui/master/static/d3.v2.min.js
> src/webui/master/static/dashboard.js
> src/webui/master/static/graph.css
> src/webui/master/static/index.html 342082d15328986246bda214129650dcb541b45a
> src/webui/master/static/jquery.pailer.js
> src/webui/master/static/loading.gif
> src/webui/master/static/mesos.css 34f60673ee7fda7558c63d953318131410901020
> src/webui/master/static/pailer.html f91761202966296b940091bfb34e1b52cdd97027
> src/webui/master/static/relative-date.js
> src/webui/master/static/ui-bootstrap-tpls-0.4.0.js
> src/webui/master/static/ui-bootstrap-tpls-0.4.0.min.js
> src/webui/master/static/underscore-1.4.3.js
> src/webui/master/static/underscore-1.4.3.min.js
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12733/diff/
>
>
> Testing
> -------
>
> * Rendered every template to ensure paths were correct
> * Ran `make` to ensure Makefile.am paths were correct, and all files were added/removed as needed
>
>
> Thanks,
>
> Ross Allen
>
>