You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@xerces.apache.org by "Jesse Pelton (JIRA)" <xe...@xml.apache.org> on 2006/05/11 16:34:05 UTC

[jira] Commented: (XERCESC-1593) critical Warning on compiling XercesC 2.7.0

    [ http://issues.apache.org/jira/browse/XERCESC-1593?page=comments#action_12379077 ] 

Jesse Pelton commented on XERCESC-1593:
---------------------------------------

These may or may not actually be problems. I took a look at the code that causes the first warning to be generated (in TraverseSchem.cpp) and concluded that it's safe. That said, I had to look at it pretty closely to reach this conclusion because the logic is a bit obscure. (It's clear that the offending statement can't be reached unless completeWildCard is set, but it's not obvious that if completeWildCard is set, defAttType will also be set.)

Likewise for Token.cpp: it's safe, but a bit obscure.

Bottom line: while these warnings correlate to code that is somewhat hard to read, careful analysis of each instance is required to determine whether there's actually anything wrong and whether there's an alternative that's easier for humans and compilers to analyze, correct, and efficient. A patch, anyone?

> critical Warning on compiling XercesC 2.7.0
> -------------------------------------------
>
>          Key: XERCESC-1593
>          URL: http://issues.apache.org/jira/browse/XERCESC-1593
>      Project: Xerces-C++
>         Type: Bug

>   Components: Build
>     Versions: 2.7.0
>  Environment: MSVC 2003 (7.1)
> Set Warning Level to 4
>     Reporter: Lukas Grützmacher

>
> I've compiled XercesC 2.7.0 from sources with MSVC2003.
> I've changed the project settings to use always warning level 4.
> Thereby I found a lot of warnings. IMHO some of them are critical:
> xerces-c-src_2_7_0\src\xercesc\validators\schema\traverseschema.cpp(6490) : warning C4701: local variable 'defAttType' may be used without having been initialized
> xerces-c-src_2_7_0\src\xercesc\util\regx\token.cpp(259) : warning C4701: local variable 'ret2' may be used without having been initialized
> xerces-c-src_2_7_0\src\xercesc\util\regx\RegularExpression.cpp(184) : warning C4244: 'argument' : conversion from 'XMLInt32' to 'const XMLCh', possible loss of data
> xerces-c-src_2_7_0\src\xercesc\util\platforms\win32\win32platformutils.cpp(795) : warning C4701: local variable 'retVal' may be used without having been initialized
> xerces-c-src_2_7_0\tests\xserializertest\xserializertest.cpp(537) : warning C4701: local variable 'duration' may be used without having been initialized
> Many others are not critical but sould be fixed, too. Here are some examples:
> DFAContentModel.cpp
> ..\..\..\..\..\src\xercesc\validators\common\CMNode.hpp(129) : warning C4245: 'initializing' : conversion from 'int' to 'unsigned int', signed/unsigned mismatch
> xerces-c-src_2_7_0\src\xercesc\internal\XSAXMLScanner.cpp(310) : warning C4245: 'argument' : conversion from '' to 'unsigned int', signed/unsigned mismatch
> xerces-c-src_2_7_0\src\xercesc\framework\psvi\XSValue.cpp(1721) : warning C4189: 'strLen' : local variable is initialized but not referenced
> xerces-c-src_2_7_0\src\xercesc\dom\deprecated\DOM_RangeException.cpp(36) : warning C4244: 'argument' : conversion from 'xercesc_2_7::DOM_RangeException::RangeExceptionCode' to 'short', possible loss of data

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org