You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@milagro.apache.org by GitBox <gi...@apache.org> on 2020/05/09 02:15:40 UTC
[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #30: Tests HKDF for SHA2-384
kirk-baird opened a new issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30
# What is the issue
There are currently no tests for SHA2-384 (`HASH384`).
# What needs to be done
Tests need to be written, unfortunately SHA2-384 does not have test cases in the [rfc](https://tools.ietf.org/html/rfc5869) like SHA2-256 or SHA2-512.
Thus, test vectors should be obtained from alternate sources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] giorgiozoppi commented on issue #30: Tests HKDF for SHA2-384
Posted by GitBox <gi...@apache.org>.
giorgiozoppi commented on issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30#issuecomment-931935174
Ok. I can generate with Python hashlib.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] giorgiozoppi commented on issue #30: Tests HKDF for SHA2-384
Posted by GitBox <gi...@apache.org>.
giorgiozoppi commented on issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30#issuecomment-931647443
@kirk-baird assign to me since i am in learning curve to Rust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] giorgiozoppi edited a comment on issue #30: Tests HKDF for SHA2-384
Posted by GitBox <gi...@apache.org>.
giorgiozoppi edited a comment on issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30#issuecomment-931647443
@kirk-baird assign to me since i am in learning curve to Rust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] giorgiozoppi commented on issue #30: Tests HKDF for SHA2-384
Posted by GitBox <gi...@apache.org>.
giorgiozoppi commented on issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30#issuecomment-931908182
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] kirk-baird commented on issue #30: Tests HKDF for SHA2-384
Posted by GitBox <gi...@apache.org>.
kirk-baird commented on issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30#issuecomment-931910917
> Done.
Excellent, are you able to make a Pull Request so it can be merged in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] kirk-baird commented on issue #30: Tests HKDF for SHA2-384
Posted by GitBox <gi...@apache.org>.
kirk-baird commented on issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30#issuecomment-931913442
> BTW do you have a roadmap, ideas for this?
It would be good to have some tests similar to this https://github.com/apache/incubator-milagro-crypto-rust/blob/develop/src/hash256.rs#L368 but for the HKDF `hash384.rs`.
Unfortunately they are not provided in the RFC https://tools.ietf.org/html/rfc5869 where the protocol is defined.
So the test cases would have to be gathered from somewhere else, likely find another implementation and output the results from that and ensure they match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] giorgiozoppi commented on issue #30: Tests HKDF for SHA2-384
Posted by GitBox <gi...@apache.org>.
giorgiozoppi commented on issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30#issuecomment-931911641
BTW do you have a roadmap, ideas for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] giorgiozoppi commented on issue #30: Tests HKDF for SHA2-384
Posted by GitBox <gi...@apache.org>.
giorgiozoppi commented on issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30#issuecomment-931911511
Yes, i will do in the next days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] kirk-baird commented on issue #30: Tests HKDF for SHA2-384
Posted by GitBox <gi...@apache.org>.
kirk-baird commented on issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30#issuecomment-931775563
> @kirk-baird assign to me since i am in learning curve to Rust.
Sure thing happy to assign this to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-rust] kirk-baird edited a comment on issue #30: Tests HKDF for SHA2-384
Posted by GitBox <gi...@apache.org>.
kirk-baird edited a comment on issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30#issuecomment-931775563
> @kirk-baird assign to me since i am in learning curve to Rust.
Sure thing happy to assign this to you.
I don't have admin permissions to assign you on github. I'm happy for you to work on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org