You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/28 12:27:50 UTC

[GitHub] [arrow] rodrigojdebem commented on a change in pull request #10385: ARROW-12858: [C++][Gandiva] Add isNull, isTrue, isFalse, isNotTrue, IsNotFalse and NVL functions on Gandiva

rodrigojdebem commented on a change in pull request #10385:
URL: https://github.com/apache/arrow/pull/10385#discussion_r641509120



##########
File path: cpp/src/gandiva/function_registry_datetime.cc
##########
@@ -36,6 +36,7 @@ namespace gandiva {
 
 std::vector<NativeFunction> GetDateTimeFunctionRegistry() {
   static std::vector<NativeFunction> date_time_fn_registry_ = {
+      UNARY_SAFE_NULL_NEVER_BOOL(isnull, {}, day_time_interval),

Review comment:
       @projjal I added `ISNULL` for `day_time_interval` and `month_interval` because the rest already has it implemented.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org