You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/07/23 18:55:35 UTC

[GitHub] [accumulo] ctubbsii commented on a change in pull request #1289: Improve internal error handling & javadoc

ctubbsii commented on a change in pull request #1289: Improve internal error handling & javadoc
URL: https://github.com/apache/accumulo/pull/1289#discussion_r306478803
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/clientImpl/MasterClient.java
 ##########
 @@ -103,17 +103,8 @@ public static void close(MasterClientService.Iface iface) {
         sleepUninterruptibly(100, TimeUnit.MILLISECONDS);
       } catch (ThriftSecurityException e) {
         throw new AccumuloSecurityException(e.user, e.code, e);
-      } catch (AccumuloException e) {
+      } catch (AccumuloException | ThriftTableOperationException e) {
         throw e;
-      } catch (ThriftTableOperationException e) {
 
 Review comment:
   The intent here was to avoid leaking RPC types. Are we sure we want to throw the Thrift exception type outside of this method now? I think I'd prefer we didn't. I like the RPC code to be confined.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services