You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "KeDeng (Code Review)" <ge...@cloudera.org> on 2025/07/03 07:16:10 UTC
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23116
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
[build] Add support for Rocky in build toolchain scripts
This patch introduces a custom_run_at_rocky() helper function
that configures the build environment to use the system-provided
GCC and G++ compilers on Rocky Linux. If ccache is available and
CC/CXX are unset, the function enables ccache by setting CC and
CXX accordingly.
The function mimics the behavior of custom_run_at_sles(), but
targets Rocky Linux systems using the default compiler toolchain.
Currently, the function has been tested on Rocky Linux 9 only.
It may not cover all versions of Rocky Linux. Future adjustments
will be made as issues arise on other versions.
Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
---
M build-support/enable_devtoolset.sh
1 file changed, 34 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/23116/1
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23116 )
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1535/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Jul 2025 08:01:03 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23116 )
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1535/
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Jul 2025 07:16:18 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23116
to look at the new patch set (#2).
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
[build] Add support for Rocky in build toolchain scripts
This patch introduces a custom_run_at_rocky() helper function
that configures the build environment to use the system-provided
GCC and G++ compilers on Rocky Linux. If ccache is available and
CC/CXX are unset, the function enables ccache by setting CC and
CXX accordingly.
The function mimics the behavior of custom_run_at_sles(), but
targets Rocky Linux systems using the default compiler toolchain.
Currently, the function has been tested on Rocky Linux 9 only.
It may not cover all versions of Rocky Linux. Future adjustments
will be made as issues arise on other versions.
Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
---
M build-support/enable_devtoolset.sh
1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/23116/2
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23116 )
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Jul 2025 10:49:18 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23116 )
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
Patch Set 2: Verified+1
unrelated test failures
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 15:51:09 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23116 )
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
[build] Add support for Rocky in build toolchain scripts
This patch introduces a custom_run_at_rocky() helper function
that configures the build environment to use the system-provided
GCC and G++ compilers on Rocky Linux. If ccache is available and
CC/CXX are unset, the function enables ccache by setting CC and
CXX accordingly.
The function mimics the behavior of custom_run_at_sles(), but
targets Rocky Linux systems using the default compiler toolchain.
Currently, the function has been tested on Rocky Linux 9 only.
It may not cover all versions of Rocky Linux. Future adjustments
will be made as issues arise on other versions.
Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Reviewed-on: http://gerrit.cloudera.org:8080/23116
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M build-support/enable_devtoolset.sh
1 file changed, 30 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23116 )
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23116/1/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
http://gerrit.cloudera.org:8080/#/c/23116/1/build-support/enable_devtoolset.sh@86
PS1, Line 86: # If CC/CXX are not set already, set them to system defaults.
nit: is this a stray comment? it seems this should be at line 103
http://gerrit.cloudera.org:8080/#/c/23116/1/build-support/enable_devtoolset.sh@97
PS1, Line 97: else
: export CC="/usr/bin/gcc"
: export CXX="/usr/bin/g++"
Should this be removed because of the code at lines lines 105 and 106?
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 05:11:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23116 )
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1598/
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 11:14:41 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23116 )
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1598/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 12:26:50 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Add support for Rocky in build toolchain scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23116 )
Change subject: [build] Add support for Rocky in build toolchain scripts
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6
Gerrit-Change-Number: 23116
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 15:51:17 +0000
Gerrit-HasComments: No