[GitHub] [pulsar] jerrypeng commented on a change in pull request #7193: function to read compacted topics

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #7193:
URL: https://github.com/apache/pulsar/pull/7193#discussion_r437614293



##########
File path: pulsar-functions/proto/src/main/proto/Function.proto
##########
@@ -94,6 +94,7 @@ message ConsumerSpec {
         int32 value = 1;
     }
     ReceiverQueueSize receiverQueueSize = 4;
+    bool readCompacted = 5;

Review comment:
       We already have a ConsumerConfig class:
   
   https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/java/org/apache/pulsar/common/functions/ConsumerConfig.java
   
   Though I am for refactoring this to be generic Map so we don't have to make code changes for new consumer configs that are added.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org