[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #7233: Remove additional cast from TPCH q8

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #7233:
URL: https://github.com/apache/arrow-datafusion/pull/7233#discussion_r1287667131


##########
benchmarks/queries/q8.sql:
##########
@@ -1,9 +1,9 @@
 select
     o_year,
-    cast(cast(sum(case
-                      when nation = 'BRAZIL' then volume
-                      else 0
-        end) as decimal(12,2)) / cast(sum(volume) as decimal(12,2)) as decimal(15,2)) as mkt_share
+    sum(case
+            when nation = 'BRAZIL' then volume
+            else 0
+        end) / sum(volume) as mkt_share

Review Comment:
   These cast are added before to work around overflow issue.
   
   After https://github.com/apache/arrow-datafusion/pull/6832, q8 should pass without cast.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org