You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "htyoung (via GitHub)" <gi...@apache.org> on 2023/11/23 13:58:38 UTC
[PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
htyoung opened a new pull request, #27504:
URL: https://github.com/apache/doris/pull/27504
## Proposed changes
Issue Number: close #27474
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1862549497
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1862991269
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1826788248
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1825858947
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.47 seconds
stream load tsv: 571 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17096999459 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1831071218
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1860864390
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1825847266
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 03834dda5472f009aba7aeab2a5fb1e1cb4cf4b6, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4878 4630 4629 4629
q2 356 158 159 158
q3 2018 1899 1912 1899
q4 1392 1284 1240 1240
q5 3963 3954 4049 3954
q6 254 126 132 126
q7 1417 866 876 866
q8 2777 2797 2773 2773
q9 9638 9545 9428 9428
q10 3434 3545 3526 3526
q11 389 250 254 250
q12 436 284 291 284
q13 4587 3794 3773 3773
q14 317 284 286 284
q15 579 526 515 515
q16 661 589 581 581
q17 1136 960 962 960
q18 7913 7350 7576 7350
q19 1677 1689 1677 1677
q20 539 289 297 289
q21 4442 3937 4006 3937
q22 483 371 375 371
Total cold run time: 53286 ms
Total hot run time: 48870 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4604 4573 4541 4541
q2 342 234 258 234
q3 4069 4019 4029 4019
q4 2704 2699 2705 2699
q5 9844 9833 9737 9737
q6 245 122 121 121
q7 3043 2463 2489 2463
q8 4486 4480 4470 4470
q9 12963 12740 12776 12740
q10 4088 4179 4145 4145
q11 755 720 677 677
q12 973 821 818 818
q13 4280 3557 3559 3557
q14 376 361 352 352
q15 575 513 522 513
q16 719 664 665 664
q17 3824 3889 3893 3889
q18 9611 9094 8999 8999
q19 1806 1787 1798 1787
q20 2397 2085 2055 2055
q21 8774 8789 8590 8590
q22 900 805 837 805
Total cold run time: 81378 ms
Total hot run time: 77875 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1863059721
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.52 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17184112924 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1826728366
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1826735397
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.79 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 29 seconds loaded 2358488459 Bytes, about 77 MB/s
stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17101658023 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1860966889
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.82 seconds
stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17219794821 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1863050573
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit ca3426e1c9de26566dccfb34ce969127de6dd318, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4650 4380 4392 4380
q2 363 140 138 138
q3 1452 1228 1205 1205
q4 1110 905 890 890
q5 3151 3197 3200 3197
q6 248 142 141 141
q7 1002 484 504 484
q8 2193 2272 2197 2197
q9 6735 6701 6687 6687
q10 3227 3307 3291 3291
q11 304 186 181 181
q12 352 215 207 207
q13 4553 3778 3815 3778
q14 235 207 210 207
q15 575 517 528 517
q16 440 378 385 378
q17 1001 600 549 549
q18 7134 7028 7089 7028
q19 1526 1343 1409 1343
q20 550 309 297 297
q21 3077 2667 2664 2664
q22 345 277 280 277
Total cold run time: 44223 ms
Total hot run time: 40036 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4362 4345 4353 4345
q2 269 165 170 165
q3 3539 3531 3528 3528
q4 2388 2371 2378 2371
q5 5765 5740 5745 5740
q6 239 120 123 120
q7 2402 1861 1859 1859
q8 3525 3528 3538 3528
q9 9139 9075 9050 9050
q10 3910 4013 4009 4009
q11 494 372 380 372
q12 760 602 598 598
q13 4278 3553 3576 3553
q14 281 251 259 251
q15 573 521 523 521
q16 509 456 459 456
q17 1906 1862 1869 1862
q18 8705 8249 8274 8249
q19 1707 1789 1719 1719
q20 2246 1945 1930 1930
q21 6504 6208 6195 6195
q22 494 413 422 413
Total cold run time: 63995 ms
Total hot run time: 60834 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1826733047
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 1af025676e430ecabb5e2f5d85ae12e34a2c4364, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4904 4687 4644 4644
q2 356 163 157 157
q3 2046 1903 1915 1903
q4 1380 1265 1259 1259
q5 3956 3960 4000 3960
q6 249 131 136 131
q7 1436 890 891 890
q8 2825 2803 2792 2792
q9 9719 9561 9451 9451
q10 3481 3541 3530 3530
q11 382 241 241 241
q12 436 289 288 288
q13 4576 3802 3777 3777
q14 316 292 282 282
q15 584 524 530 524
q16 667 584 576 576
q17 1141 978 910 910
q18 7686 7379 7266 7266
q19 1698 1702 1684 1684
q20 571 319 286 286
q21 4417 3942 3996 3942
q22 485 373 380 373
Total cold run time: 53311 ms
Total hot run time: 48866 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4581 4610 4592 4592
q2 344 238 251 238
q3 4030 3991 3969 3969
q4 2692 2673 2680 2673
q5 9651 9691 9631 9631
q6 241 128 123 123
q7 3008 2484 2479 2479
q8 4468 4472 4499 4472
q9 12869 12850 12816 12816
q10 4047 4163 4158 4158
q11 766 664 686 664
q12 989 799 815 799
q13 4319 3507 3548 3507
q14 365 360 359 359
q15 575 524 521 521
q16 720 665 691 665
q17 3869 3863 3825 3825
q18 9525 8951 8975 8951
q19 1835 1776 1783 1776
q20 2367 2065 2080 2065
q21 8790 8548 8481 8481
q22 870 781 811 781
Total cold run time: 80921 ms
Total hot run time: 77545 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1825211719
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1825077269
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1825712934
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1825211757
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1831179796
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.82 seconds
stream load tsv: 584 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.3 seconds inserted 10000000 Rows, about 353K ops/s
storage size: 17099574160 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #27504:
URL: https://github.com/apache/doris/pull/27504#discussion_r1403957287
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableStmt.java:
##########
@@ -715,12 +714,16 @@ public String toSql() {
}
}
sb.append("\n)");
- sb.append(" ENGINE = ").append(engineName);
+ sb.append(" ENGINE = ").append(engineName.toUpperCase());
Review Comment:
use toLowerCase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1831172155
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit febfb95fe59bc461f481d4edfd952289162fe5f5, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4933 4654 4639 4639
q2 351 172 159 159
q3 1516 1318 1294 1294
q4 1155 1002 943 943
q5 3253 3244 3275 3244
q6 246 136 131 131
q7 985 525 549 525
q8 2239 2250 2242 2242
q9 7008 6984 6963 6963
q10 3315 3400 3376 3376
q11 343 213 204 204
q12 349 217 229 217
q13 4656 3907 3908 3907
q14 251 219 214 214
q15 584 529 525 525
q16 427 369 396 369
q17 1023 673 616 616
q18 7739 7289 7457 7289
q19 1543 1519 1568 1519
q20 534 325 310 310
q21 3381 2977 2966 2966
q22 369 295 303 295
Total cold run time: 46200 ms
Total hot run time: 41947 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4605 4585 4613 4585
q2 320 196 213 196
q3 3735 3734 3730 3730
q4 2523 2527 2507 2507
q5 6177 6165 6163 6163
q6 248 123 121 121
q7 2696 1988 2009 1988
q8 3765 3715 3705 3705
q9 9403 9409 9318 9318
q10 4076 4168 4145 4145
q11 638 520 499 499
q12 807 622 647 622
q13 4378 3653 3614 3614
q14 267 248 244 244
q15 599 518 524 518
q16 507 481 475 475
q17 2125 2067 2057 2057
q18 9493 8973 9026 8973
q19 1863 1783 1768 1768
q20 2314 1984 1970 1970
q21 7067 6835 7134 6835
q22 658 569 584 569
Total cold run time: 68264 ms
Total hot run time: 64602 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "htyoung (via GitHub)" <gi...@apache.org>.
htyoung commented on code in PR #27504:
URL: https://github.com/apache/doris/pull/27504#discussion_r1403973686
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableStmt.java:
##########
@@ -715,12 +714,16 @@ public String toSql() {
}
}
sb.append("\n)");
- sb.append(" ENGINE = ").append(engineName);
+ sb.append(" ENGINE = ").append(engineName.toUpperCase());
Review Comment:
It has been modified to toLowerCase, and the code format has been adjusted using the project's IntelliJ-code-format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1860959210
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 7220d14cba738801f2c9f8e43a3d7e47542e9923, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4767 4485 4507 4485
q2 365 160 156 156
q3 1471 1239 1202 1202
q4 1125 907 908 907
q5 3188 3222 3158 3158
q6 251 131 133 131
q7 1003 495 482 482
q8 2221 2243 2213 2213
q9 6748 6731 6702 6702
q10 3244 3239 3267 3239
q11 329 197 204 197
q12 361 210 212 210
q13 4594 3814 3815 3814
q14 238 212 218 212
q15 572 523 528 523
q16 448 392 385 385
q17 1029 675 607 607
q18 7264 6959 6889 6889
q19 1554 1455 1394 1394
q20 539 316 304 304
q21 3097 2710 2730 2710
q22 353 281 288 281
Total cold run time: 44761 ms
Total hot run time: 40201 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4476 4452 4418 4418
q2 267 165 172 165
q3 3567 3546 3549 3546
q4 2422 2417 2401 2401
q5 5742 5861 5773 5773
q6 247 126 126 126
q7 2396 1880 1860 1860
q8 3555 3550 3556 3550
q9 9071 8999 9052 8999
q10 3918 3990 4018 3990
q11 491 395 396 395
q12 782 610 597 597
q13 4311 3549 3595 3549
q14 284 261 262 261
q15 572 521 529 521
q16 508 475 456 456
q17 1927 1841 1876 1841
q18 8641 8388 8342 8342
q19 1755 1798 1779 1779
q20 2266 1954 1938 1938
q21 6604 6268 6235 6235
q22 517 422 423 422
Total cold run time: 64319 ms
Total hot run time: 61164 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27504:
URL: https://github.com/apache/doris/pull/27504#issuecomment-1862993210
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](stmt):fix CreateTableStmt toSql placed comment in wrong place [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #27504:
URL: https://github.com/apache/doris/pull/27504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org