You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/14 01:46:26 UTC

[GitHub] [beam] pabloem commented on a diff in pull request #22966: [#22478]: Add read_time support to Google Firestore connector

pabloem commented on code in PR #22966:
URL: https://github.com/apache/beam/pull/22966#discussion_r965359778


##########
sdks/java/io/google-cloud-platform/build.gradle:
##########
@@ -196,6 +196,8 @@ task integrationTest(type: Test, dependsOn: processTestResources) {
   exclude '**/BigQueryIOStorageWriteIT.class'
   exclude '**/BigQueryToTableIT.class'
   exclude '**/BigQueryIOJsonTest.class'
+  // TODO Firestore IT test needs to run in a separate project from Datastore.
+  exclude '**/FirestoreV1IT.class'

Review Comment:
   thanks for adding these. what can we do to ensure these run somewhere?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org