[GitHub] merlimat commented on a change in pull request #2691: Automatic schema update can be disabled through admin interface

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #2691: Automatic schema update can be disabled through admin interface
URL: https://github.com/apache/pulsar/pull/2691#discussion_r223800931
 
 

 ##########
 File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/SchemaAutoUpdateCompatibilityStrategy.java
 ##########
 @@ -0,0 +1,45 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pulsar.common.policies.data;
+
+/**
+ * Strategy to use when checking an auto-updated schema for compatibility to the current schema.
+ */
+public enum SchemaAutoUpdateCompatibilityStrategy {
+    /**
+     * Don't allow any auto updates.
+     */
+    AutoUpdateDisabled,
+
+    /**
+     * Messages written in the new schema can be read by the previous schema.
 
 Review comment:
   Can we expand the comments to clarify in terms of what happens when you try to use a producer with a newer/older version of the schema?
   
   > Messages written in the new schema can be read by the previous schema.
   
   Does that mean that it will update the topic schema only if the new one can be read by a an old client? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services