You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by arina-ielchiieva <gi...@git.apache.org> on 2018/03/02 13:32:55 UTC

[GitHub] drill pull request #1146: DRILL-6204: Pass tables columns without partition ...

GitHub user arina-ielchiieva opened a pull request:

    https://github.com/apache/drill/pull/1146

    DRILL-6204: Pass tables columns without partition columns to empty Hi…

    …ve reader
    
    Details in [DRILL-6204](https://issues.apache.org/jira/browse/DRILL-6204).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arina-ielchiieva/drill DRILL-6204

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1146
    
----
commit 50dd97c612645d025dc3fa77795e142eabee2b70
Author: Arina Ielchiieva <ar...@...>
Date:   2018-03-02T11:38:00Z

    DRILL-6204: Pass tables columns without partition columns to empty Hive reader

----


---

[GitHub] drill pull request #1146: DRILL-6204: Pass tables columns without partition ...

Posted by vdiravka <gi...@git.apache.org>.

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1146#discussion_r171912800
  
    --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java ---
    @@ -174,7 +174,7 @@ public ScanBatch getBatch(ExecutorFragmentContext context, HiveDrillNativeParque
         // If there are no readers created (which is possible when the table is empty or no row groups are matched),
         // create an empty RecordReader to output the schema
         if (readers.size() == 0) {
    -      readers.add(new HiveDefaultReader(table, null, null, columns, context, conf,
    +      readers.add(new HiveDefaultReader(table, null, null, newColumns, context, conf,
    --- End diff --
    
    Could we rename newColumns -> nonPartitionedColumns or tableColumns?


---

[GitHub] drill issue #1146: DRILL-6204: Pass tables columns without partition columns...

Posted by arina-ielchiieva <gi...@git.apache.org>.

Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/1146
  
    @parthchandra, @vdiravka please review.


---

[GitHub] drill issue #1146: DRILL-6204: Pass tables columns without partition columns...

Posted by parthchandra <gi...@git.apache.org>.

Github user parthchandra commented on the issue:

    https://github.com/apache/drill/pull/1146
  
    +1


---

[GitHub] drill pull request #1146: DRILL-6204: Pass tables columns without partition ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/1146


---

[GitHub] drill issue #1146: DRILL-6204: Pass tables columns without partition columns...

Posted by arina-ielchiieva <gi...@git.apache.org>.

Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/1146
  
    @vdiravka, thanks for the code review. Updated PR.


---