[jira] [Commented] (OFBIZ-10697) ControlEventListener improvement: check debug level

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713967#comment-16713967 ] 

Jacques Le Roux commented on OFBIZ-10697:
-----------------------------------------

Hi Michael,

I guess you know already but in case. In OFBIZ-10052
bq. we agreed about better doing a check when using Debug.logVerbose().
And in OFBIZ-10448 I explained to Mathieu:
bq. IMO for the other debug levels it's unnecessary because they are defined in debug.properties as used (at least OOTB, and I'd not recommend false in production for them!). We have 934 "if (Debug." in code with among them 622 "if (Debug.ver". I'd be all for removing the 312 useless cases but not the "if (Debug.verboseOn())" 

> ControlEventListener improvement: check debug level
> ---------------------------------------------------
>
>                 Key: OFBIZ-10697
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10697
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk, Release Branch 17.12
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>
> The Debug.logXXX statements should be preceded with a check for the debug level to optimize the performance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)