You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mintsweet (via GitHub)" <gi...@apache.org> on 2023/03/17 01:45:16 UTC
[GitHub] [incubator-devlake] mintsweet opened a new pull request, #4696: fix(config-ui): missed timeAfter after change data scope
mintsweet opened a new pull request, #4696:
URL: https://github.com/apache/incubator-devlake/pull/4696
### Summary
Missed `timeAfter` after change data scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh merged pull request #4696: fix(config-ui): missed timeAfter after change data scope
Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh merged PR #4696:
URL: https://github.com/apache/incubator-devlake/pull/4696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4696: fix(config-ui): missed timeAfter after change data scope
Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh commented on code in PR #4696:
URL: https://github.com/apache/incubator-devlake/pull/4696#discussion_r1139552933
##########
config-ui/src/pages/blueprint/detail/panel/configuration.tsx:
##########
@@ -96,7 +96,7 @@ export const Configuration = ({ blueprint, operating, onUpdate, onRefresh }: Pro
const handleUpdateConnection = (updated: any) =>
onUpdate({
settings: {
- version: '2.0.0',
+ ...blueprint.settings,
Review Comment:
If the empty time filter hasn't been pass to the backend, I think we should fix this issue in backend. 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #4696: fix(config-ui): missed timeAfter after change data scope
Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on code in PR #4696:
URL: https://github.com/apache/incubator-devlake/pull/4696#discussion_r1139557757
##########
config-ui/src/pages/blueprint/detail/panel/configuration.tsx:
##########
@@ -96,7 +96,7 @@ export const Configuration = ({ blueprint, operating, onUpdate, onRefresh }: Pro
const handleUpdateConnection = (updated: any) =>
onUpdate({
settings: {
- version: '2.0.0',
+ ...blueprint.settings,
Review Comment:
I tried an empty timeAfter and it still works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org