You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/12 21:25:59 UTC
[GitHub] [hadoop-ozone] sodonnel opened a new pull request #1070: HDDS-3785. Update topology.aware.read parameter in ozone-topology compose config
sodonnel opened a new pull request #1070:
URL: https://github.com/apache/hadoop-ozone/pull/1070
## What changes were proposed in this pull request?
HDDS-1865 updated the parameter dfs.network.topology.aware.read.enable to ozone.network.topology.aware.read, but in the docker-compose config for ozone-topology, the old parameter is still used.
This Jira is to update it to the new value.
From OzoneConfigKeys.java, we can see the correct value for this parameter:
```
public static final String OZONE_NETWORK_TOPOLOGY_AWARE_READ_KEY =
"ozone.network.topology.aware.read";
public static final boolean OZONE_NETWORK_TOPOLOGY_AWARE_READ_DEFAULT = false;
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3785?
## How was this patch tested?
existing tests and manual tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1070: HDDS-3785. Update topology.aware.read parameter in ozone-topology compose config
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #1070:
URL: https://github.com/apache/hadoop-ozone/pull/1070#issuecomment-643731936
Thank You @sodonnel for the fix and @vivekratnavel and @xiaoyuyao for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1070: HDDS-3785. Update topology.aware.read parameter in ozone-topology compose config
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1070:
URL: https://github.com/apache/hadoop-ozone/pull/1070#issuecomment-643508362
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1070?src=pr&el=h1) Report
> Merging [#1070](https://codecov.io/gh/apache/hadoop-ozone/pull/1070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/bd88eec9fec06a8f8adcbe4d257c5ccaca144f4c&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1070 +/- ##
============================================
+ Coverage 69.36% 69.37% +0.01%
- Complexity 9097 9107 +10
============================================
Files 961 961
Lines 48127 48127
Branches 4676 4676
============================================
+ Hits 33383 33390 +7
+ Misses 12524 12522 -2
+ Partials 2220 2215 -5
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1070?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...hdds/scm/container/CloseContainerEventHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1070/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2NvbnRhaW5lci9DbG9zZUNvbnRhaW5lckV2ZW50SGFuZGxlci5qYXZh) | `72.41% <0.00%> (-17.25%)` | `6.00% <0.00%> (ø%)` | |
| [.../apache/hadoop/hdds/scm/node/StaleNodeHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1070/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL25vZGUvU3RhbGVOb2RlSGFuZGxlci5qYXZh) | `88.88% <0.00%> (-11.12%)` | `4.00% <0.00%> (ø%)` | |
| [...e/commandhandler/CloseContainerCommandHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1070/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlbWFjaGluZS9jb21tYW5kaGFuZGxlci9DbG9zZUNvbnRhaW5lckNvbW1hbmRIYW5kbGVyLmphdmE=) | `82.45% <0.00%> (-3.51%)` | `11.00% <0.00%> (ø%)` | |
| [...zone/container/common/volume/MutableVolumeSet.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1070/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3ZvbHVtZS9NdXRhYmxlVm9sdW1lU2V0LmphdmE=) | `75.00% <0.00%> (-0.90%)` | `39.00% <0.00%> (-1.00%)` | |
| [...mon/transport/server/ratis/XceiverServerRatis.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1070/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvcmF0aXMvWGNlaXZlclNlcnZlclJhdGlzLmphdmE=) | `90.23% <0.00%> (-0.60%)` | `54.00% <0.00%> (ø%)` | |
| [...doop/ozone/container/keyvalue/KeyValueHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1070/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIva2V5dmFsdWUvS2V5VmFsdWVIYW5kbGVyLmphdmE=) | `61.11% <0.00%> (+0.22%)` | `63.00% <0.00%> (+2.00%)` | |
| [.../transport/server/ratis/ContainerStateMachine.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1070/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvcmF0aXMvQ29udGFpbmVyU3RhdGVNYWNoaW5lLmphdmE=) | `69.36% <0.00%> (+0.22%)` | `59.00% <0.00%> (+1.00%)` | |
| [.../apache/hadoop/ozone/om/OmMetadataManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1070/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9PbU1ldGFkYXRhTWFuYWdlckltcGwuamF2YQ==) | `82.52% <0.00%> (+0.26%)` | `92.00% <0.00%> (+1.00%)` | |
| [.../ozone/container/common/volume/AbstractFuture.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1070/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3ZvbHVtZS9BYnN0cmFjdEZ1dHVyZS5qYXZh) | `30.38% <0.00%> (+0.51%)` | `20.00% <0.00%> (+1.00%)` | |
| [...ine/commandhandler/DeleteBlocksCommandHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1070/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlbWFjaGluZS9jb21tYW5kaGFuZGxlci9EZWxldGVCbG9ja3NDb21tYW5kSGFuZGxlci5qYXZh) | `64.06% <0.00%> (+1.56%)` | `11.00% <0.00%> (+2.00%)` | |
| ... and [5 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1070?src=pr&el=footer). Last update [bd88eec...d58faed](https://codecov.io/gh/apache/hadoop-ozone/pull/1070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #1070: HDDS-3785. Update topology.aware.read parameter in ozone-topology compose config
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #1070:
URL: https://github.com/apache/hadoop-ozone/pull/1070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org